Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching to reanalyze_all. #487

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Add batching to reanalyze_all. #487

merged 2 commits into from
Nov 26, 2023

Conversation

n-rook
Copy link
Owner

@n-rook n-rook commented Nov 12, 2023

It currently times out in staging.

I'm too scared to deploy to prod without this 😬

Fixes #196

Copy link
Collaborator

@jgdhs27 jgdhs27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

"reanalyze_batch/<int:start_token>/<int:end_token>",
reanalyze_all_replays.reanalyze_page,
name="Replays/ReanalyzePagePost",
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is the form post endpoint. I had to make a separate endpoint so I could give it both the start and end tokens.

@n-rook
Copy link
Owner Author

n-rook commented Nov 26, 2023

Thanks!

@n-rook n-rook merged commit 9cff93c into main Nov 26, 2023
4 checks passed
@n-rook n-rook deleted the nrook/batch-reanalyze branch November 26, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "reanalyze_all" page so that it only analyzes a fixed number of replays at a time
2 participants