refactor: netsim #66
refactor: netsim #66
Conversation
|
@flub tagged you in for a quick look around if you like, given you're our resident python expert and shown some interest in this bit. This part 1 of 3. |
netsim/net/network.py
Outdated
| "A Node with multicast stuff." | ||
| class EdgeNode( Node ): | ||
| def config( self, **params ): | ||
| super( EdgeNode, self).config( **params ) |
There was a problem hiding this comment.
Do you still need this super syntax? I think this is python 2.7's super syntax. For 3.x you should use super().config(**params) IIRC.
(also, what's with all the spacing around the bracket in this file? not very consistent)
netsim/net/network.py
Outdated
| self.cmd( 'smcroutectl -I smcroute-' + self.name + | ||
| ' join ' + intfName + ' 239.0.0.1' ) | ||
|
|
||
| def terminate( self ): |
There was a problem hiding this comment.
Consider making this class a context manager
Thank you. I mostly tagged you in to have someone else from the team be aware of it's existence (but I also knew you would give some input :) ) It's more/better than expected. A lot of the code base was cobbled together from different pieces and copy paste didn't do me a great service to keep things aligned. Starting with a formatter is a great 1st step. |
More or less a complete redo of netsim.