write build_go_mac.sh file to set up go package so it can be installed more seamlessly #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
changed the title
| # to run you need to let the linker know where the linked library files are: | ||
| # LD_LIBRARY_PATH="${LD_LIBRARY_PATH:-}:./iroh/ffi" \ | ||
| # CGO_LDFLAGS="-liroh -L ./iroh/ffi" \ | ||
| # go <actual go command to build or run> |
There was a problem hiding this comment.
should this stay here?
There was a problem hiding this comment.
yes, unfortunately from my linux experimentation, it won't recognize the linked files, no matter where I put libiroh.so. Either the box I was using was ignoring it, or maybe something was wrong with how it was set up for dynamic linking, but I couldn't get it to recognize the cgo flag. I needed to still add the LD_LIBRARY_PATH manually. So until that's confirmed to work I want to leave these instructions in.
...-go/iroh-node-go/blobs/e09187884bce6d0b24c58ae9fb511b541ffb4d200e502b64517837ec56bbc599.data
Outdated
Show resolved
Hide resolved
dignifiedquire
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linux machines still don't want to recognize
cgo LDFLAG, but this brings us one step closer and cleaner to getting a golang setting to be smoother.Updates the README for how to build the golang bindings for each platform.