Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh-relay): fix client actors not closing #3134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PaulOlteanu
Copy link
Contributor

@PaulOlteanu PaulOlteanu commented Jan 16, 2025

Description

When a client actor closes, it awaits Clients::unregister, which then awaits for the actor task to close, so almost every actor task was being leaked. Since the only place Clients::unregister is called is from when the actor is already closing, I chose to break the cycle by not have it call Client::shutdown.

I also added a timeout to the tls handshake because that also gets stuck forever if the client goes away. I didn't add it to the LetsEncrypt acceptor because I wasn't sure where exactly it belonged, but that should probably have one too. I can move this to a separate PR if preferred. Maybe the timeout should be configurable as well?

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant