fix(iroh-relay): fix client actors not closing #3134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a client actor closes, it awaits
Clients::unregister
, which then awaits for the actor task to close, so almost every actor task was being leaked. Since the only placeClients::unregister
is called is from when the actor is already closing, I chose to break the cycle by not have it callClient::shutdown
.I also added a timeout to the tls handshake because that also gets stuck forever if the client goes away. I didn't add it to the
LetsEncrypt
acceptor because I wasn't sure where exactly it belonged, but that should probably have one too. I can move this to a separate PR if preferred. Maybe the timeout should be configurable as well?Notes & open questions
Change checklist