-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new project syncing setup #3136
base: main
Are you sure you want to change the base?
Conversation
|
||
on: | ||
schedule: | ||
- cron: '0 0,6,12,18 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a different schedule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add manually triggering so that you're not entirely stuck.
But also, maybe every 1h? Or are there rate limits we need to worry about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with every hour unless there are rate limits.
And also, if possible a manual trigger.
- cron: '0 0,6,12,18 * * *' | ||
|
||
env: | ||
REPOS_LIST: "iroh-doctor-server quinn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to list out all the repos we're interested in. @ramfox unless you have specifics I'll just either add a very long list we used for the last iteration or try to just do all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones we did for the last iteration should be right!
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3136/docs/iroh/ Last updated: 2025-01-17T13:28:24Z |
|
||
on: | ||
schedule: | ||
- cron: '0 0,6,12,18 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add manually triggering so that you're not entirely stuck.
But also, maybe every 1h? Or are there rate limits we need to worry about?
Description
Revamps how we track PRs and Issues to add onto repos. Mainly because this produced issues with forks but also did all the work attribution to me.
The downside of this approach is that it runs on a schedule (set to every 6 hours but we can change). Also if GH api craps out on us we have to wait till the next trigger.
Breaking Changes
Notes & open questions
Change checklist