refactor: Use n0-future in favor of futures-* libraries and tokio::{spawn,task,time}
#3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iroh/src/discovery/pkarr.rs
Outdated
| let republish = tokio::time::sleep(Duration::MAX); | ||
| tokio::pin!(republish); | ||
| let republish = time::sleep(Duration::MAX); | ||
| n0_future::pin!(republish); |
There was a problem hiding this comment.
nit: the pin macro exists in the std lib
There was a problem hiding this comment.
Seems like it doesn't work though. If I use std::pin::pin!(republish) it doesn't compile for me 🤔
dignifiedquire
approved these changes
Jan 29, 2025
We need `flatten_stream`, which isn't re-exported in n0-future.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3156/docs/iroh/ Last updated: 2025-01-29T15:28:14Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
futures_lite,futures_util,futures_sinkandfutures_bufferedwith re-exports fromn0_future.std::timewithn0_future::timetokio::{spawn,task,time}withn0_future::{spawn,task,time}tokio::time::advancethat we don't have n0-future yet. It's also not strictly necessary for shipping e.g. browser stuff.The goal of this PR is
Essentially this is work extracted out of the browser PRs.
Breaking Changes
I don't think there are any breaking changes from this.
It's possible that
JoinSetorJoinHandletypes leak from the interfaces somewhere, but they're identical to the old ones (just re-exports) outside ofwasm*-*-unknowntargets.Notes & open questions
I've tried setting up semgrep, but (1) IIUC, setting it up for CI requires that you have an account with them, only running locally is free and (2) I haven't found a way to ignore e.g.
std::timeimports when you're inside a*::testsmodule, which means we'd either need to convert all our tests ton0-futureor ignore warnings and I think both of these options might suck.Change checklist