Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support eth domains #543

Merged
merged 7 commits into from
Nov 26, 2022

Conversation

ppodolsky
Copy link
Contributor

This PR does two things:

  • Moved DNS resolver to dedicated struct and reused it instead of creation every time
  • Added resolver.cloudflare-eth.com resolver for .eth domains as in Kubo for making possible to resolve Etherium domains. Ip addresses of resolver are hardcoded for avoiding excessive round-trip.

@ppodolsky ppodolsky changed the title [feat] Support eth domains feat: Support eth domains Nov 24, 2022
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits, but other than that this is looking good

@n0-computer n0-computer deleted a comment from codecov bot Nov 25, 2022
@dignifiedquire dignifiedquire merged commit 1d6b825 into n0-computer:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants