iroh-net transport #105
Draft
iroh-net transport #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
reviewed
Nov 1, 2024
src/transport/iroh_net.rs
Outdated
| let allowed_node_ids = match access_control { | ||
| AccessControl::Unrestricted => BTreeSet::new(), | ||
| AccessControl::Allowed(list) if list.is_empty() => { | ||
| tracing::warn!( |
There was a problem hiding this comment.
I think empty should mean nobody has access. E.g. you got a config file where you define allowed node ids, and you set this to [] accidentally or because you want to remove access. This should not make it unrestricted.
There was a problem hiding this comment.
Yeah, makes sense indeed, I will remove this warn! and return an error instead, better fail early than being unresponsive for all requests
As it would indicate a possible misconfiguration elsewhere
|
I merged the new naming and the change to how mapping works. So there will be quite some conflicts. Should not be anything complex though, since neither the transports themselves nor the interaction patterns stuff has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft on iroh-net transport implementation for quic-rpc. It's heavily based on quinn transport. It has a bunch of duplicated code from quinn transport too, that I can abstract away between these two transports if needed.
Leaving it as a draft for now because it's failing the
server_away_and_backtest for some reason andiroh_net_channel_benchtest performance seem to be much worse than respective quinn transport test. I know that communicating through iroh-net will have extra overheads when comparing to communication over quinn with proper direct addresses. But I'm not 100% sure that this totally explains the extra time it takes compared to quinn transport.