Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to [email protected] #11

Merged
merged 14 commits into from
Aug 7, 2024
Merged

Upgrade to [email protected] #11

merged 14 commits into from
Aug 7, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Jun 20, 2024

This upgrades the dependencies to work with Rustls 0.23

Part of n0-computer/iroh#2273

@matheus23 matheus23 marked this pull request as ready for review August 6, 2024 10:37
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please make sure to do some manual testing

@matheus23
Copy link
Contributor

@dignifiedquire Good call!
There was a call to reqwest::ClientBuilder::use_preconfigured_tls which takes an impl Any which used to expect an Arc<rustls::ClientConfig>, but now expects just a rustls::ClientConfig directly.

I only found this bug after trying to deploy the high_level example from this crate.

Again, good call.
Fixed the issue, and tested with https://philipp.iroh.link (I'll keep it up for a bit). Also tested with letsencrypt prod, so now it's just serving TLS via letsencrypt's root CA.

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@dignifiedquire
Copy link
Contributor

please document somewhere that this uses the ring backend only for rustls

@matheus23 matheus23 merged commit 7b39efc into main Aug 7, 2024
7 checks passed
@matheus23
Copy link
Contributor

Eh - comments loaded late.
Will open a new PR!

@matheus23
Copy link
Contributor

Opened #13

@tmpfs
Copy link
Contributor

tmpfs commented Aug 8, 2024

@flub, @dignifiedquire and @matheus23 - thanks a lot for landing this!

I've taken it for a spin and it seems to be working well, could I trouble you for a 0.4 release please as I would like to be able to publish my code which depends on tokio-rustls-acme to crates.io.

Cheers 🚀

@matheus23
Copy link
Contributor

Haha yeah I'm hoping we can get a release out today, too. We need this as well.

@matheus23
Copy link
Contributor

@tmpfs we've released version 0.4.0 :) 🎉

@dignifiedquire dignifiedquire deleted the rustls-23 branch August 12, 2024 11:55
@tmpfs
Copy link
Contributor

tmpfs commented Aug 13, 2024

Thanks @matheus23 for the heads up, this has unblocked me so much appreciated 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants