* fix violation of Roslyn analyzer rule CA1872 @ ClientRequester.cs
#266
n0099Annotations
3 errors, 11 warnings, and 30 notices
|
runs-on (macos-latest) / ReSharper
Issues found.
|
|
runs-on (ubuntu-latest) / ReSharper
Issues found.
|
|
runs-on (windows-latest) / ReSharper
Issues found.
|
|
runs-on (ubuntu-latest) / build (tbClient)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
runs-on (ubuntu-latest) / build (imagePipeline)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
runs-on (ubuntu-latest) / build (shared)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
runs-on (ubuntu-latest) / build (crawler)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
runs-on (macos-latest) / ReSharper:
c%23/imagePipeline/src/Consumer/MetadataConsumer.cs#L245
"[CA1859] Change type of parameter 'dms' from 'System.Collections.Generic.IReadOnlyList<double>' to 'System.Collections.Generic.List<double>' for improved performance" on /Users/runner/work/open-tbm/open-tbm/c%23/imagePipeline/src/Consumer/MetadataConsumer.cs(245,68)
|
|
runs-on (macos-latest) / ReSharper:
c%23/imagePipeline/src/ImageBatchConsumingWorker.cs#L46
"[CA1859] Change type of parameter 'imagesWithBytes' from 'System.Collections.Generic.IReadOnlyCollection<tbm.ImagePipeline.ImageWithBytes>' to 'System.Collections.Generic.List<tbm.ImagePipeline.ImageWithBytes>' for improved performance" on /Users/runner/work/open-tbm/open-tbm/c%23/imagePipeline/src/ImageBatchConsumingWorker.cs(46,45)
|
|
runs-on (ubuntu-latest) / ReSharper
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/imagePipeline/src/Consumer/MetadataConsumer.cs#L245
"[CA1859] Change type of parameter 'dms' from 'System.Collections.Generic.IReadOnlyList<double>' to 'System.Collections.Generic.List<double>' for improved performance" on /home/runner/work/open-tbm/open-tbm/c%23/imagePipeline/src/Consumer/MetadataConsumer.cs(245,68)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/imagePipeline/src/ImageBatchConsumingWorker.cs#L46
"[CA1859] Change type of parameter 'imagesWithBytes' from 'System.Collections.Generic.IReadOnlyCollection<tbm.ImagePipeline.ImageWithBytes>' to 'System.Collections.Generic.List<tbm.ImagePipeline.ImageWithBytes>' for improved performance" on /home/runner/work/open-tbm/open-tbm/c%23/imagePipeline/src/ImageBatchConsumingWorker.cs(46,45)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/imagePipeline/src/Consumer/MetadataConsumer.cs#L245
"[CA1859] Change type of parameter 'dms' from 'System.Collections.Generic.IReadOnlyList<double>' to 'System.Collections.Generic.List<double>' for improved performance" on /D:/a/open-tbm/open-tbm/c%23/imagePipeline/src/Consumer/MetadataConsumer.cs(245,68)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/imagePipeline/src/ImageBatchConsumingWorker.cs#L46
"[CA1859] Change type of parameter 'imagesWithBytes' from 'System.Collections.Generic.IReadOnlyCollection<tbm.ImagePipeline.ImageWithBytes>' to 'System.Collections.Generic.List<tbm.ImagePipeline.ImageWithBytes>' for improved performance" on /D:/a/open-tbm/open-tbm/c%23/imagePipeline/src/ImageBatchConsumingWorker.cs(46,45)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Crawler/CrawlerLocks.cs#L101
"[CanReplaceCastWithLambdaReturnType] Cast expression can be replaced with statically typed language construct" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Crawler/CrawlerLocks.cs(101,29)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/IRevisionProperties.cs#L10
"[CanReplaceCastWithLambdaReturnType] Cast expression can be replaced with statically typed language construct" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/IRevisionProperties.cs(10,14)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs#L94
"[MemberCanBePrivate.Global] Record 'UniqueAuthorRevision' can be made private" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs(94,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/ClientRequesterTcs.cs#L10
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/ClientRequesterTcs.cs(10,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs#L22
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs(22,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs#L29
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs(29,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs#L25
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs(25,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs#L24
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs(24,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/UserSaver.cs#L64
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/UserSaver.cs(64,5)
|
|
runs-on (macos-latest) / ReSharper:
c%23/imagePipeline/src/Ocr/TesseractRecognizer.cs#L8
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /Users/runner/work/open-tbm/open-tbm/c%23/imagePipeline/src/Ocr/TesseractRecognizer.cs(8,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Crawler/CrawlerLocks.cs#L101
"[CanReplaceCastWithLambdaReturnType] Cast expression can be replaced with statically typed language construct" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Crawler/CrawlerLocks.cs(101,29)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/IRevisionProperties.cs#L10
"[CanReplaceCastWithLambdaReturnType] Cast expression can be replaced with statically typed language construct" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/IRevisionProperties.cs(10,14)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs#L94
"[MemberCanBePrivate.Global] Record 'UniqueAuthorRevision' can be made private" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs(94,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/ClientRequesterTcs.cs#L10
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/ClientRequesterTcs.cs(10,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs#L22
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs(22,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs#L29
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs(29,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs#L25
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs(25,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs#L24
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs(24,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/crawler/src/Tieba/Crawl/Saver/UserSaver.cs#L64
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/UserSaver.cs(64,5)
|
|
runs-on (ubuntu-latest) / ReSharper:
c%23/imagePipeline/src/Ocr/TesseractRecognizer.cs#L8
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /home/runner/work/open-tbm/open-tbm/c%23/imagePipeline/src/Ocr/TesseractRecognizer.cs(8,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Crawler/CrawlerLocks.cs#L101
"[CanReplaceCastWithLambdaReturnType] Cast expression can be replaced with statically typed language construct" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Crawler/CrawlerLocks.cs(101,29)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/IRevisionProperties.cs#L10
"[CanReplaceCastWithLambdaReturnType] Cast expression can be replaced with statically typed language construct" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/IRevisionProperties.cs(10,14)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs#L94
"[MemberCanBePrivate.Global] Record 'UniqueAuthorRevision' can be made private" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs(94,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/ClientRequesterTcs.cs#L10
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/ClientRequesterTcs.cs(10,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs#L22
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Facade/CrawlFacade.cs(22,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs#L29
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ReplySaver.cs(29,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs#L25
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs(25,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs#L24
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/Post/ThreadSaver.cs(24,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/UserSaver.cs#L64
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/crawler/src/Tieba/Crawl/Saver/UserSaver.cs(64,5)
|
|
runs-on (windows-latest) / ReSharper:
D:/a/open-tbm/open-tbm/c%23/imagePipeline/src/Ocr/TesseractRecognizer.cs#L8
"[ReplaceWithFieldKeyword] Replace with 'field' keyword" on /D:/a/open-tbm/open-tbm/c%23/imagePipeline/src/Ocr/TesseractRecognizer.cs(8,5)
|