Skip to content

* fix some violations of ReSharper inspections #40

* fix some violations of ReSharper inspections

* fix some violations of ReSharper inspections #40

Triggered via push March 24, 2024 07:20
Status Failure
Total duration 2m 30s
Artifacts

c#.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 10 notices
ReSharper
Issues found.
ReSharper: c#/crawler/src/Tieba/Crawl/Saver/SaverChangeSet.cs#L27
"[CollectionNeverUpdated.Global] Content of collection 'AllAfter' is never updated" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/SaverChangeSet.cs(27,1061)
ReSharper: c#/crawler/src/Tieba/Crawl/Crawler/BaseCrawler.cs#L6
"[UnusedParameter.Global] Parameter 'flag' is not used in any of the implementations" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Crawler/BaseCrawler.cs(6,268)
ReSharper: c#/crawler/src/Tieba/Crawl/CrawlPost.cs#L131
"[SuggestBaseTypeForParameter] Parameter can be of type 'System.Collections.Generic.IReadOnlyCollection<tbm.Crawler.Tieba.Crawl.Saver.SaverChangeSet<tbm.Crawler.Db.Post.ThreadPost>>'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/CrawlPost.cs(131,6446)
ReSharper: c#/crawler/src/Tieba/Crawl/Facade/BaseCrawlFacade.cs#L84
"[InvertIf] Invert 'if' statement to reduce nesting" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Facade/BaseCrawlFacade.cs(84,3827)
ReSharper: c#/crawler/src/Tieba/Crawl/Parser/BaseParser.cs#L27
"[UnusedMemberInSuper.Global] Only overrides of method 'Convert' are used" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Parser/BaseParser.cs(27,1100)
ReSharper: c#/crawler/src/Tieba/Crawl/Saver/ReplySaver.cs#L126
"[MergeIntoPattern] Merge into pattern" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/ReplySaver.cs(126,6013)
ReSharper: c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs#L79
"[InvertIf] Invert 'if' statement to reduce nesting" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs(79,4615)
ReSharper: c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs#L92
"[ParameterTypeCanBeEnumerable.Local] Parameter can be of type 'IEnumerable<Type>'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs(92,5277)
ReSharper: c#/crawler/src/Tieba/Crawl/ThreadLateCrawlerAndSaver.cs#L122
"[InvertIf] Invert 'if' statement to reduce nesting" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/ThreadLateCrawlerAndSaver.cs(122,5497)
ReSharper: c#/crawler/src/Worker/ArchiveCrawlWorker.cs#L21
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Worker/ArchiveCrawlWorker.cs(21,1332)
ReSharper: c#/crawler/src/Worker/ArchiveCrawlWorker.cs#L22
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Worker/ArchiveCrawlWorker.cs(22,1374)