* replace #pragma warning (disable|restore) directives with `[Suppr…
#43
n0099Annotations
1 error, 36 warnings, and 10 notices
|
ReSharper
Issues found.
|
|
build (tbClient)
Cache save failed.
|
|
build (shared)
Cache save failed.
|
|
build (shared):
c#/shared/src/TbmDbContext.cs#L100
Make 'OnModelCreatingWithFid' method static. (https://code-cracker.github.io/diagnostics/CC0091.html)
|
|
build (shared):
c#/shared/src/TbmDbContext.cs#L100
Make 'OnModelCreatingWithFid' method static. (https://code-cracker.github.io/diagnostics/CC0091.html)
|
|
build (imagePipeline):
c#/shared/src/TbmDbContext.cs#L100
Make 'OnModelCreatingWithFid' method static. (https://code-cracker.github.io/diagnostics/CC0091.html)
|
|
build (imagePipeline):
c#/imagePipeline/Program.cs#L1
Missing XML comment for internally visible type or member 'Program' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/2305.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/MetadataConsumer.cs#L300
Add RegexOptions.ExplicitCapture to prevent capturing unneeded groups (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0023.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Db/ImageMetadata.cs#L46
Property 'DownloadedByteSize' contains the name of its containing type 'ByteSize' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1710.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/JointRecognizer.cs#L12
Field '_paddleOcrRecognizerAndDetector' contains the word 'and', which suggests doing multiple things (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1115.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/PaddleOcrRecognizerAndDetector.cs#L7
Type 'PaddleOcrRecognizerAndDetector' contains the word 'and', which suggests it has multiple purposes (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1000.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/PaddleOcrRecognizerAndDetector.cs#L50
Type 'PaddleOcrRecognizerAndDetector' contains the word 'and', which suggests it has multiple purposes (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1000.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/TesseractRecognizer.cs#L140
Property 'PreprocessedTextBoxMat' contains the name of its containing type 'PreprocessedTextBox' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1710.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Db/ImageMetadata.cs#L217
'InfoHeaderType' is not a valid parameter name (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0015.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Db/ImageMetadata.cs#L219
'BitsPerPixel' is not a valid parameter name (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0015.md)
|
|
build (crawler)
Cache save failed.
|
|
build (crawler):
c#/shared/src/TbmDbContext.cs#L100
Make 'OnModelCreatingWithFid' method static. (https://code-cracker.github.io/diagnostics/CC0091.html)
|
|
build (crawler):
c#/crawler/Program.cs#L1
Missing XML comment for internally visible type or member 'Program' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/2305.md)
|
|
build (crawler):
c#/crawler/src/Helper.cs#L24
Overloaded method 'Helper.GetNowTimestamp()' should call another overload (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1551.md)
|
|
build (crawler):
c#/crawler/src/Helper.cs#L6
Name of type 'Helper' contains the term 'Helper' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1708.md)
|
|
build (crawler):
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L29
Name of type 'ModelBuilderHelper' contains the term 'Helper' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1708.md)
|
|
build (crawler):
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L8
Prefer using collection abstraction instead of implementation (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0016.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Crawler/ThreadArchiveCrawler.cs#L5
'ThreadArchiveCrawler.New' hides inherited member (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1010.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/CrawlerLocks.cs#L12
Property 'RegisteredCrawlerLocks' contains the name of its containing type 'CrawlerLocks' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1710.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/CrawlerLocks.cs#L12
Prefer using collection abstraction instead of implementation (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0016.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs#L3
Name of type 'StaticCommonInSavers' contains the term 'Common' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1708.md)
|
|
ReSharper
Cache save failed.
|
|
ReSharper:
c#/crawler/Program.cs#L1
"[AV2305] Missing XML comment for internally visible type or member 'Program'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/Program.cs
|
|
ReSharper:
c#/crawler/src/Db/ProtoBufRepeatedFieldJsonConverter.cs#L8
"[MA0025] Implement the functionality (or raise NotSupportedException or PlatformNotSupportedException)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/ProtoBufRepeatedFieldJsonConverter.cs(8,316)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L8
"[MA0016] Prefer using collection abstraction instead of implementation" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(8,252)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L10
"[MA0025] Implement the functionality (or raise NotSupportedException or PlatformNotSupportedException)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(10,372)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L29
"[AV1708] Name of type 'ModelBuilderHelper' contains the term 'Helper'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(29,1178)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L31
"[CC0091] Make 'HasKey' method static." on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(31,1267)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L35
"[CC0091] Make 'SplittingHasKeyAndName' method static." on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(35,1494)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L35
"[AV1115] Method 'SplittingHasKeyAndName' contains the word 'and', which suggests doing multiple things" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(35,1494)
|
|
ReSharper:
c#/crawler/src/ExtensionMethods.cs#L37
"[AV1532] Loop statement contains nested loop" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(37,1397)
|
|
ReSharper:
c#/crawler/src/Helper.cs#L6
"[AV1708] Name of type 'Helper' contains the term 'Helper'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Helper.cs(6,115)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L31
"[MA0038] Make method static (deprecated, use CA1822 instead)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(31,1267)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L35
"[MA0038] Make method static (deprecated, use CA1822 instead)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(35,1494)
|
|
ReSharper:
c#/crawler/src/ExtensionMethods.cs#L3
"[AV1008] Class 'ExtensionMethods' should be non-static or its name should be suffixed with 'Extensions'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(3,52)
|
|
ReSharper:
c#/crawler/src/ExtensionMethods.cs#L3
"[AV1745] Name of extension method container class 'ExtensionMethods' should end with 'Extensions'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(3,52)
|
|
ReSharper:
c#/crawler/src/ExtensionMethods.cs#L70
"[AV1568] The value of parameter 'toCheck' is overwritten in its method body" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(70,2731)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0001] Use an overload of 'Replace' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1237)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0001] Use an overload of 'Replace' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1237)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0001] Use an overload of 'Replace' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1237)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0089] Use an overload with char instead of string" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1249)
|
|
ReSharper:
c#/crawler/src/Tieba/ClientRequester.cs#L56
"[MA0001] Use an overload of 'Contains' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/ClientRequester.cs(56,2326)
|