* rename nested class ModelBuilderHelper to ModelBuilderExtension…
#44
n0099Annotations
1 error, 34 warnings, and 10 notices
|
ReSharper
Issues found.
|
|
build (shared)
Cache save failed.
|
|
build (imagePipeline)
Cache save failed.
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/MetadataConsumer.cs#L300
Add RegexOptions.ExplicitCapture to prevent capturing unneeded groups (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0023.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/JointRecognizer.cs#L12
Field '_paddleOcrRecognizerAndDetector' contains the word 'and', which suggests doing multiple things (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1115.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Db/ImageMetadata.cs#L46
Property 'DownloadedByteSize' contains the name of its containing type 'ByteSize' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1710.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/PaddleOcrRecognizerAndDetector.cs#L7
Type 'PaddleOcrRecognizerAndDetector' contains the word 'and', which suggests it has multiple purposes (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1000.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/PaddleOcrRecognizerAndDetector.cs#L50
Type 'PaddleOcrRecognizerAndDetector' contains the word 'and', which suggests it has multiple purposes (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1000.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Ocr/TesseractRecognizer.cs#L140
Property 'PreprocessedTextBoxMat' contains the name of its containing type 'PreprocessedTextBox' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1710.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/HashConsumer.cs#L16
Type ImgHashBase is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/HashConsumer.cs#L17
Type ImgHashBase is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/HashConsumer.cs#L18
Type ImgHashBase is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/HashConsumer.cs#L19
Type ImgHashBase is used in a collection lookup but does not override Equals() and GetHashCode() (https://github.com/Vannevelj/SharpSource/blob/master/docs/SS004-ElementaryMethodsOfTypeInCollectionNotOverridden.md)
|
|
build (tbClient)
Cache save failed.
|
|
build (crawler):
c#/crawler/src/Helper.cs#L26
Overloaded method 'Helper.GetNowTimestamp()' should call another overload (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1551.md)
|
|
build (crawler):
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L8
Prefer using collection abstraction instead of implementation (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0016.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/CommonInSavers.cs#L5
Name of type 'CommonInSavers' contains the term 'Common' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1708.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/CommonInSavers.cs#L11
Prefer using collection abstraction instead of implementation (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0016.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/CrawlerLocks.cs#L12
Property 'RegisteredCrawlerLocks' contains the name of its containing type 'CrawlerLocks' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1710.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/CrawlerLocks.cs#L12
Prefer using collection abstraction instead of implementation (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0016.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/BaseSaver.cs#L15
The delegate must have 2 parameters (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0046.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs#L3
Name of type 'StaticCommonInSavers' contains the term 'Common' (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1708.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/StaticCommonInSavers.cs#L9
Prefer using collection abstraction instead of implementation (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0016.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/UserParserAndSaver.cs#L5
Type 'UserParserAndSaver' contains the word 'and', which suggests it has multiple purposes (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1000.md)
|
|
ReSharper
Cache save failed.
|
|
ReSharper:
c#/crawler/src/Db/ProtoBufRepeatedFieldJsonConverter.cs#L8
"[MA0025] Implement the functionality (or raise NotSupportedException or PlatformNotSupportedException)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/ProtoBufRepeatedFieldJsonConverter.cs(8,316)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L8
"[MA0016] Prefer using collection abstraction instead of implementation" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(8,252)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L10
"[MA0025] Implement the functionality (or raise NotSupportedException or PlatformNotSupportedException)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(10,372)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L35
"[AV1115] Method 'SplittingHasKeyAndName' contains the word 'and', which suggests doing multiple things" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(35,1497)
|
|
ReSharper:
c#/crawler/src/Helper.cs#L10
"[AV1130] Return type in signature for 'Helper.SerializedProtoBufOrNullIfEmpty(IMessage?)' should be an interface to an unchangeable collection" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Helper.cs(10,312)
|
|
ReSharper:
c#/crawler/src/Helper.cs#L13
"[AV1130] Return type in signature for 'Helper.SerializedProtoBufWrapperOrNullIfEmpty<T>(IEnumerable<T>?, Func<IMessage?>)' should be an interface to an unchangeable collection" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Helper.cs(13,485)
|
|
ReSharper:
c#/crawler/src/Helper.cs#L19
"[AV1130] Return type in signature for 'Helper.ParseThenUnwrapPostContent(byte[]?)' should be an interface to an unchangeable collection" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Helper.cs(19,838)
|
|
ReSharper:
c#/crawler/src/Helper.cs#L26
"[AV1551] Overloaded method 'Helper.GetNowTimestamp()' should call another overload" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Helper.cs(26,1262)
|
|
ReSharper:
c#/crawler/src/Tieba/ClientRequester.cs#L22
"[MA0016] Prefer using collection abstraction instead of implementation" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/ClientRequester.cs(22,729)
|
|
ReSharper:
c#/crawler/src/Tieba/ClientRequester.cs#L91
"[MA0002] Use an overload that has a IEqualityComparer<string> or IComparer<string> parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/ClientRequester.cs(91,3731)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L31
"[MA0038] Make method static (deprecated, use CA1822 instead)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(31,1270)
|
|
ReSharper:
c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L35
"[MA0038] Make method static (deprecated, use CA1822 instead)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(35,1497)
|
|
ReSharper:
c#/crawler/src/ExtensionMethods.cs#L3
"[AV1745] Name of extension method container class 'ExtensionMethods' should end with 'Extensions'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(3,52)
|
|
ReSharper:
c#/crawler/src/ExtensionMethods.cs#L70
"[AV1568] The value of parameter 'toCheck' is overwritten in its method body" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(70,2731)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0001] Use an overload of 'Replace' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1237)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0001] Use an overload of 'Replace' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1237)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0001] Use an overload of 'Replace' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1237)
|
|
ReSharper:
c#/crawler/src/SonicPusher.cs#L33
"[MA0089] Use an overload with char instead of string" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/SonicPusher.cs(33,1249)
|
|
ReSharper:
c#/crawler/src/Tieba/ClientRequester.cs#L56
"[MA0001] Use an overload of 'Contains' that has a StringComparison parameter" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/ClientRequester.cs(56,2326)
|
|
ReSharper:
c#/crawler/src/Tieba/ClientRequester.cs#L81
"[MA0076] Do not use implicit culture-sensitive ToString in interpolated strings" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/ClientRequester.cs(81,3449)
|