Skip to content

* prefer I?ReadOnlyDictionary<,> over I?Dictionary<,> #52

* prefer I?ReadOnlyDictionary<,> over I?Dictionary<,>

* prefer I?ReadOnlyDictionary<,> over I?Dictionary<,> #52

Triggered via push April 1, 2024 16:50
Status Failure
Total duration 3m 2s
Artifacts

c#.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 3 warnings, and 10 notices
ReSharper: c#/shared/src/BaseEntryPoint.cs#L9
"[CA1716] Rename namespace tbm.Shared so that it no longer conflicts with the reserved language keyword 'Shared'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace." on /home/runner/work/open-tbm/open-tbm/c#/shared/src/BaseEntryPoint.cs(9,239)
ReSharper: c#/shared/src/ErrorableWorker.cs#L32
"[CA1848] For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])'" on /home/runner/work/open-tbm/open-tbm/c#/shared/src/ErrorableWorker.cs(32,1580)
ReSharper: c#/shared/src/ErrorableWorker.cs#L38
"[CA1848] For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.LogError(ILogger, Exception?, string?, params object?[])'" on /home/runner/work/open-tbm/open-tbm/c#/shared/src/ErrorableWorker.cs(38,1872)
ReSharper
Issues found.
ReSharper: c#/crawler/src/ExtensionMethods.cs#L3
"[PartialTypeWithSinglePart] Partial class with single part" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(3,38)
ReSharper: c#/crawler/src/GlobalUsings.cs#L62
"[RedundantUsingDirective.Global] Global using directive is not required by the code and can be safely removed" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/GlobalUsings.cs(62,2339)
ReSharper: c#/crawler/src/Tieba/Crawl/Saver/SaverChangeSet.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/SaverChangeSet.cs
ReSharper: c#/crawler/src/Db/Post/IPost.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/IPost.cs(7,185)
ReSharper: c#/crawler/src/Db/Post/ReplyPost.cs#L14
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/ReplyPost.cs(14,484)
ReSharper: c#/crawler/src/Db/Post/SubReplyPost.cs#L14
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/SubReplyPost.cs(14,487)
ReSharper: c#/crawler/src/Db/Post/ThreadPost.cs#L17
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/ThreadPost.cs(17,600)
ReSharper: c#/crawler/src/Db/Post/ThreadPost.cs#L21
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/ThreadPost.cs(21,778)
ReSharper: c#/crawler/src/Db/ReplySignature.cs#L6
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/ReplySignature.cs(6,122)
ReSharper: c#/crawler/src/Db/Revision/AuthorRevision.cs#L9
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/AuthorRevision.cs(9,272)
ReSharper: c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L33
"[MA0038] Make method static (deprecated, use CA1822 instead)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(33,1359)
ReSharper: c#/crawler/src/Db/Revision/RevisionWithSplitting.cs#L37
"[MA0038] Make method static (deprecated, use CA1822 instead)" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs(37,1586)
ReSharper: c#/crawler/src/Db/Revision/ThreadRevisions.cs#L18
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/ThreadRevisions.cs(18,592)