Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furniture Model Proposed Update #22

Closed
wants to merge 7 commits into from
Closed

Conversation

crencricca
Copy link
Collaborator

Summary

Issue #12

This pull request includes proposed changes to the Furniture data model. The hope is that these changes will resolve the issues we were having with the inventory taking process being too tedious and confusing.

FURNITURE MODEL UPDATES:

REMOVED:

  • Material enum (trivial information; should be unnecessary if pictures are included or could be replaced by description field)
  • Bed class (separated parts) and hasFrame/hasBoxspring attributes in Physical
  • "set" information...tedious and confusing to input

ADDED:

  • separate components for mattress, boxspring, bed frame
  • description field for furniture

DESIGN DECISIONS

  • decided to include bed ends as part of bed frame rather than adding a separate class
  • removed "set" information...Need another solution (maybe a separate class for sets; or might not be necessary at all)
  • Tomkins County Zone might be better replaced with zip code? N2N staff seemed confused by this
  • might want to add Bed class back in to represent a matching mattress, boxspring, and frame set

Test Plan

N/A until changes are agreed upon by the team.

Notes

For now, nothing has been actually changed -- I put the proposed updates in FurnitureRework.ts. In order to actually implement the changes, a lot of reworking will have to be done in the app/Firebase furniture collection.

@kungpaogao
Copy link
Member

I think we need to discuss this further before making changes to the models. I think it might be a good idea to think of a solution for "migrating" our database before we make changes (for the future).

@kungpaogao kungpaogao closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants