Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complexity refactoring #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complexity refactoring #8

wants to merge 1 commit into from

Conversation

mestachs
Copy link

@mestachs mestachs commented May 2, 2013

First thanks for the gem !
I worked on the style, complexity and duplication in the current version.
I've added

  • sqllite support (not sure if the data are accurate but do the job in development).
  • made the created_at column configurable (can become eg last_viewed_at)

Before

flog

114.8: CohortMe::analyze lib/cohort_me.rb:5

flay

  1. Similar code found in :lasgn (mass = 34)
    lib/cohort_me.rb:45
    lib/cohort_me.rb:47

After

flog

56.1: CohortMe::analyze ./lib/cohort_me.rb:6
30.0: CohortMe::as_table ./lib/cohort_me.rb:42

flay

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant