feat(editor): Easy $fromAI Button for AI Tools #12587
Conversation
n8n-assistant
bot
added
n8n team
packages/design-system/src/components/N8nInputLabel/InputLabel.vue
Outdated
Show resolved
Hide resolved
| @@ -1505,7 +1551,14 @@ onUpdated(async () => { | |||
| <InlineExpressionTip /> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div | |||
There was a problem hiding this comment.
Would be nice to only render this wrapper div if there's a slot
There was a problem hiding this comment.
For some reason the slot exists even if the v-if condition for its template provider is not met:
<template v-if="showOverrideButton && isSingleLineInput" #overrideButton>
even with this $slots.overrideButton is truthy :/
| }; | ||
| } | ||
|
|
||
| const isContentOverride = computed(() => isOverrideValue(props.value?.toString() ?? '')); |
There was a problem hiding this comment.
nitpick - typo isContentOverriden
There was a problem hiding this comment.
hmm, this is meant as "is (a) Content Override.", not "is (this) content overridden?". Definitely want a better name here
| @@ -90,6 +91,7 @@ type Props = { | |||
| hideIssues?: boolean; | |||
| errorHighlight?: boolean; | |||
| isForCredential?: boolean; | |||
| canBeOverride?: boolean; | |||
There was a problem hiding this comment.
Do we need this prop? Can we simply check if the slot is set or not?
There was a problem hiding this comment.
Not for the edge case where we have the button in the options above, but need a 90deg top right corner for the (multi-line) expr editor
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
CharlieKolb
changed the title
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-3034
|
| Run status |
|
| Run duration | 04m 56s |
| Commit |
|
| Committer | Charlie Kolb |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
|
|
|
✅ All Cypress E2E specs passed |
Summary
Introduce infrastructure for parameterInputs to have overrides and provide an
$fromAIoverride button for applicable fields in tools.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3034/feature-add-fieldoverride-functionality-to-parameterinputfull
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)