Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(n8n Form Node): Incorporate design feedback for Custom HTML #12817

Merged
merged 8 commits into from
Feb 4, 2025
Merged

chore(n8n Form Node): Incorporate design feedback for Custom HTML #12817

merged 8 commits into from
Feb 4, 2025
+106 −24

Conversation

dana-gill
Copy link
Contributor

@dana-gill dana-gill commented Jan 23, 2025 •
edited
Loading

Summary

Incorporate design feedback for Custom HTML

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2271/add-read-onlycustom-html-form-elements
Follow up #12760

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill force-pushed the node-2271-add-read-onlycustom-html-form-elements branch from 0d1b376 to 263213f Compare January 23, 2025 16:07
@dana-gill dana-gill marked this pull request as ready for review January 23, 2025 16:09
@dana-gill dana-gill changed the title chore(Form Trigger Node): Incorporate design feedback for Custom HTML chore(n8n Form Node): Incorporate design feedback for Custom HTML Jan 23, 2025
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@dana-gill dana-gill force-pushed the node-2271-add-read-onlycustom-html-form-elements branch 2 times, most recently from 273e025 to 0722c17 Compare January 28, 2025 15:50
@dana-gill dana-gill requested a review from elsmr January 29, 2025 13:59
elsmr
elsmr previously approved these changes Jan 30, 2025
View reviewed changes
packages/cli/templates/form-trigger.handlebars Outdated Show resolved Hide resolved
@dana-gill dana-gill force-pushed the node-2271-add-read-onlycustom-html-form-elements branch from 023cca2 to a0ebc66 Compare January 31, 2025 15:06
elsmr
elsmr previously approved these changes Jan 31, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Jan 31, 2025 •
edited
Loading

n8n    Run #9118

Run Properties:  status check passed Passed #9118  •  git commit b14365c869: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 dana-gill 🗃️ e2e/*
Project n8n
Branch Review node-2271-add-read-onlycustom-html-form-elements
Run status status check passed Passed #9118
Run duration 51m 50s
Commit git commit b14365c869: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 dana-gill 🗃️ e2e/*
Committer Dana Lee
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@dana-gill dana-gill force-pushed the node-2271-add-read-onlycustom-html-form-elements branch from a0ebc66 to 9a27132 Compare January 31, 2025 16:36
@dana-gill dana-gill requested review from elsmr and removed request for elsmr January 31, 2025 17:01
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@dana-gill dana-gill force-pushed the node-2271-add-read-onlycustom-html-form-elements branch 3 times, most recently from b5ab462 to 3a0d483 Compare February 3, 2025 15:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@dana-gill dana-gill force-pushed the node-2271-add-read-onlycustom-html-form-elements branch from e1eca8f to c9bb444 Compare February 4, 2025 09:40
Joffcom
Joffcom previously approved these changes Feb 4, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

3 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@dana-gill dana-gill dismissed stale reviews from Joffcom and elsmr via b14365c February 4, 2025 14:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ All Cypress E2E specs passed

@dana-gill dana-gill merged commit ddc40ef into master Feb 4, 2025
39 checks passed
@dana-gill dana-gill deleted the node-2271-add-read-onlycustom-html-form-elements branch February 4, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

@elsmr elsmr Awaiting requested review from elsmr

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dana-gill @Joffcom @elsmr