-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Increment runIndex in WorkflowToolV2 tool executions to avoid reusing out of date inputs #13008
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CharlieKolb
changed the title
fix: Bump runIndex in WorkflowToolV2
fix: Increment runIndex in WorkflowToolV2 tool executions to avoid reusing out of date inputs
Feb 4, 2025
netroy
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix this properly in core in another PR
CharlieKolb
added
the
release/backport
Changes that need to be backported to older releases.
label
Feb 4, 2025
✅ All Cypress E2E specs passed |
n8n Run #9105
Run Properties:
|
Project |
n8n
|
Branch Review |
workflow_tool_v2_fix_multiple_calls
|
Run status |
Passed #9105
|
Run duration | 04m 48s |
Commit |
082231395a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
|
Committer | Charlie Kolb |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
5
|
Skipped |
0
|
Passing |
433
|
View all changes introduced in this branch ↗︎ |
elsmr
pushed a commit
that referenced
this pull request
Feb 4, 2025
…using out of date inputs (#13008)
elsmr
pushed a commit
that referenced
this pull request
Feb 4, 2025
…using out of date inputs (#13008)
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
n8n team
Authored by the n8n team
release/backport
Changes that need to be backported to older releases.
Released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3186/bug-workflowtool-v2-always-uses-first-row-of-input-data
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)