Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increment runIndex in WorkflowToolV2 tool executions to avoid reusing out of date inputs #13008

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

CharlieKolb
Copy link
Contributor

@CharlieKolb CharlieKolb commented Feb 3, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3186/bug-workflowtool-v2-always-uses-first-row-of-input-data

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CharlieKolb CharlieKolb changed the title bump runIndex fix: Bump runIndex in WorkflowToolV2 Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Feb 3, 2025
@CharlieKolb CharlieKolb marked this pull request as ready for review February 4, 2025 11:39
@CharlieKolb CharlieKolb changed the title fix: Bump runIndex in WorkflowToolV2 fix: Increment runIndex in WorkflowToolV2 tool executions to avoid reusing out of date inputs Feb 4, 2025
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix this properly in core in another PR

@CharlieKolb CharlieKolb added the release/backport Changes that need to be backported to older releases. label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 4, 2025

n8n    Run #9105

Run Properties:  status check passed Passed #9105  •  git commit 082231395a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Project n8n
Branch Review workflow_tool_v2_fix_multiple_calls
Run status status check passed Passed #9105
Run duration 04m 48s
Commit git commit 082231395a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@CharlieKolb CharlieKolb merged commit cc907fb into master Feb 4, 2025
39 checks passed
@CharlieKolb CharlieKolb deleted the workflow_tool_v2_fix_multiple_calls branch February 4, 2025 12:02
elsmr pushed a commit that referenced this pull request Feb 4, 2025
elsmr pushed a commit that referenced this pull request Feb 4, 2025
This was referenced Feb 4, 2025
@janober
Copy link
Member

janober commented Feb 4, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants