-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Change evaluation workflow input data format (no-changelog) #13109
base: master
Are you sure you want to change the base?
feat(core): Change evaluation workflow input data format (no-changelog) #13109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but should we cover this with some tests?
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
n8n
|
Project |
n8n
|
Branch Review |
ai-635-add-tags-or-annotations-any-tags-or-thumbs-up-thumbs-down
|
Run status |
|
Run duration | 04m 36s |
Commit |
|
Committer | Eugene Molodkin |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
434
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
✅ All Cypress E2E specs passed |
…-thumbs-up-thumbs-down
…-thumbs-up-thumbs-down # Conflicts: # packages/cli/src/evaluation.ee/test-runner/__tests__/test-runner.service.ee.test.ts # packages/cli/src/evaluation.ee/test-runner/utils.ee.ts
Summary
This PR makes the following changes to the format of data supplied to the evaluation workflow by test runner:
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)