ci: Improve the performance of the import/no-cycle linting rule (no-changelog)
#6985
Conversation
netroy
force-pushed
the
faster-no-cycle-linting
branch
from
5860c07 to
b6baf03
Compare
|
Great PR! Please pay attention to the following items before merging: Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6985 +/- ##
==========================================
- Coverage 25.12% 25.12% -0.01%
==========================================
Files 3150 3150
Lines 192169 192169
Branches 21175 21172 -3
==========================================
- Hits 48287 48284 -3
- Misses 142900 142903 +3
Partials 982 982 ☔ View full report in Codecov by Sentry. |
| @@ -324,7 +324,7 @@ const config = (module.exports = { | |||
| /** | |||
| * https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-cycle.md | |||
| */ | |||
| 'import/no-cycle': 'error', | |||
| 'import/no-cycle': ['error', { ignoreExternal: false, maxDepth: 3 }], | |||
There was a problem hiding this comment.
false is the default, did you mean to set it to true?
There was a problem hiding this comment.
it's inverted for some unclear reasons.
There was a problem hiding this comment.
What do you mean by this? I'd expect we want to ignore cycles in externals to speed up the lint right?
There was a problem hiding this comment.
I'd expect the same, but this seems to be an issue in eslint-plugin-import
Passing run #1961 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
|
Got released with |
No description provided.