feat(core): Create names for personal projects in one place and resuse it #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
commented
Mar 28, 2024
| if (this.firstName && this.lastName && this.email) { | ||
| return `${this.firstName} ${this.lastName} <${this.email}>`; | ||
| } else if (this.email) { | ||
| return `<${this.email}>`; |
There was a problem hiding this comment.
@krynble This is what it generates for shell accounts.
There was a problem hiding this comment.
One thing I'm wondering is the fact that we tested a lot of places that use this function but we haven't tested this function itself. We have 3 possible outcomes and we have no tests for it.
Would you mind adding a few tests for it?
There was a problem hiding this comment.
despairblue
commented
Mar 28, 2024
| @@ -543,7 +544,7 @@ describe('DELETE /users/:id', () => { | |||
| }); | |||
|
|
|||
| test('should fail to delete a user that does not exist', async () => { | |||
| await ownerAgent.delete('/users/foobar').query({ transferId: '' }).expect(404); | |||
There was a problem hiding this comment.
Unrelated fix for the postgres tests.
despairblue
force-pushed
the
create-default-name-for-project
branch
from
fa93117 to
5ef982b
Compare
|
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a helper function to the user entity that generates the name for the user's personal project.
Next step would be to mark the field as non-nullable in the entity and the migration.
Related tickets and issues
none
Review / Merge checklist
(no-changelog)otherwise. (conventions)