Allow 4 wire mode on Arduino - set CSN pinMode properly when CE = CSN #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since flush_rx was removed from startListening, this provides an option to flush the RX buffer in use cases where this is required.
The original #if was meaningless becasue it would always eveluate as true becasue LITTLEWIRE was already handled in an #elif above. This change allows the Tiny to still be able to use 3 wire mode, but arduinos can use a 4 wire mode, which uses CSN but not CE (CE always held high). Previously on an arduino if the CE and CSN pins were set to the same pin, then CSN pinmode was never set due to this IF
|
@soligen2010 If I had to chose between the 2 different 4-pin implementations, I'd go with #387 as it focuses on less power and the ATTiny85. The Arduino boards have plenty of pins to spare for this transceiver, so I'm not sure about the relevance for this "one line fix". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is showing multiple commits because I re-synced my fork to the master. The only real change is the last commit (a one line change)