Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate ISR handling from IRQ processing #956

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Mar 3, 2024

closes #939

This basically just moves most of the ISR logic into main loop to relieve the MCU from overperforming in IRQ events.

@2bndy5
Copy link
Member Author

2bndy5 commented Mar 3, 2024

Need to test and check the the pico SDK interrup example as well.

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Memory usage change @ 7680fa3

Board flash % RAM for global variables %
arduino:avr:nano 🔺 0 - +36 0.0 - +0.12 🔺 0 - +1 0.0 - +0.05
arduino:samd:mkrzero 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/GettingStarted
flash
% examples/GettingStarted
RAM for global variables
% examples/AcknowledgementPayloads
flash
% examples/AcknowledgementPayloads
RAM for global variables
% examples/ManualAcknowledgements
flash
% examples/ManualAcknowledgements
RAM for global variables
% examples/StreamingData
flash
% examples/StreamingData
RAM for global variables
% examples/MulticeiverDemo
flash
% examples/MulticeiverDemo
RAM for global variables
% examples/InterruptConfigure
flash
% examples/InterruptConfigure
RAM for global variables
% examples/scanner
flash
% examples/scanner
RAM for global variables
% examples/encodeRadioDetails
flash
% examples/encodeRadioDetails
RAM for global variables
%
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 36 0.12 1 0.05 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 40 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/GettingStarted<br>flash,%,examples/GettingStarted<br>RAM for global variables,%,examples/AcknowledgementPayloads<br>flash,%,examples/AcknowledgementPayloads<br>RAM for global variables,%,examples/ManualAcknowledgements<br>flash,%,examples/ManualAcknowledgements<br>RAM for global variables,%,examples/StreamingData<br>flash,%,examples/StreamingData<br>RAM for global variables,%,examples/MulticeiverDemo<br>flash,%,examples/MulticeiverDemo<br>RAM for global variables,%,examples/InterruptConfigure<br>flash,%,examples/InterruptConfigure<br>RAM for global variables,%,examples/scanner<br>flash,%,examples/scanner<br>RAM for global variables,%,examples/encodeRadioDetails<br>flash,%,examples/encodeRadioDetails<br>RAM for global variables,%
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,36,0.12,1,0.05,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,40,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@2bndy5 2bndy5 marked this pull request as ready for review March 8, 2024 07:22
@2bndy5

This comment was marked as outdated.

@2bndy5
Copy link
Member Author

2bndy5 commented Mar 8, 2024

I tested the modification on a feather RP2040. Next, I'll swap it out for my feather ESP32-S2. That should ensure the problem stated in #939 is addressed.

@TMRh20
Copy link
Member

TMRh20 commented Mar 8, 2024

Nice looking work as usual. Just gimme some time to test, shouldn't take too long.

@2bndy5
Copy link
Member Author

2bndy5 commented Mar 9, 2024

Just tested well on my QtPy ESP32-S2.

I had too much trouble trying to get the radio to work with my feather S2. I'm not sure if it was wiring (volt meter proved unlikely) or using the wrong pin numbers in code (pinout has 2 sets not including RTC numbers). It could have also been not enough current (the Feather S2 has 2 LDO regulators). Ultimately, I gave up and switched to my QtPy ESP32-S2.

Copy link
Member

@TMRh20 TMRh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to test, these examples are a bit complicated, but they work great.

@2bndy5 2bndy5 merged commit 7e97360 into master Mar 11, 2024
151 checks passed
@2bndy5 2bndy5 deleted the update-irq-example branch March 11, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 Core Panic on radio 0; No panic on Radio number 1, same wiring. How to troubleshoot?[Question]
2 participants