Simplify timeouts and enable for both servers and clients by default #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timeouts for both clients and servers by default - Change default timeout period to 45 seconds - Server-side timeouts were not working by default, now they are. Set to a higher value or 0 to disable
2bndy5
approved these changes
Oct 14, 2023
- Only set connection timer if userdata has been allocated
The initial connection logic should come first
|
FYI, the Arduino CI does the clang-format check on this repo but only for changes to examples or changes to the .github/workflows/build_arduino.yml. It would be a good idea to run clang-format-12 on this branch before merging. |
|
I probably should have pointed out that clang-format is told to ignore Dns.cpp and Dns.h files because they seem to be directly copied from the UIP library. RF24Ethernet/.github/workflows/build_arduino.yml Lines 16 to 20 in 3836331 While I like the improved readability, those file changes could be reverted in the future if desired (or if the Apache License v2.0 stipulates that any changes be explicitly noted). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIP_CONNECTION_TIMEOUTin uip-conf.h to a higher value or 0 to disableWas finding an issue I noticed in the past with the default behaviour of servers hanging up if they experienced a disconnect etc. The solution was to manually set a timeout, but it was not enabled by default. This sets it up by default to timeout of data is not received or acked in 45 seconds and simplifies the code.