Fix buffering of user payloads #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per #242 fix buffer overrun
|
Just to be sure, did you see this debug message before the changes here? Line 537 in fd8126a |
|
Yup, got that msg. it was filling up the buffer because of the added delay and overwriting the buffer for sure.
|
2bndy5
reviewed
Jan 7, 2025
2bndy5
approved these changes
Jan 10, 2025
2bndy5
pushed a commit
that referenced
this pull request
Jan 10, 2025
Issue identified by @mirhamza708 * Fix buffering of user payloads: Per #242 fix buffer overrun * Mods to #243 per @2bndy5
|
I cherry-picked this patch to the v1.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #242 fix buffer overrun