Pass /no-preprocess flag to llvm-rc 16+ #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since LLVM 16, llvm-rc supports doing the preprocessing itself. However, doing so requires having `clang` in the PATH, which some more complex toolchain may not necessarily have (for instance, for windows, you may have `clang-cl` but no `clang` in PATH, or you may have a target-prefixed clang like `x86_64-pc-windows-msvc-clang`). If llvm-rc fails to find clang, it will error out with a message saying it failed to find the program in PATH. To avoid these issues, we continue doing the preprocessing manually, and pass the /no-preprocess flag to llvm-rc.
|
It's so funny that a substring search is not part of the standard library. Validated against llvm trunk 1:18~++20231231112334+c7c912cff945-1~exp1~20231231112352.433. Applied with minor editorial changes as 25a77c4. Please close if you can, closing hasn't worked for me in weeks. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LLVM 16, llvm-rc supports doing the preprocessing itself. However, doing so requires having
clangin the PATH, which some more complex toolchain may not necessarily have (for instance, for windows, you may haveclang-clbut noclangin PATH, or you may have a target-prefixed clang likex86_64-pc-windows-msvc-clang).If llvm-rc fails to find clang, it will error out with a message saying it failed to find the program in PATH.
To avoid these issues, we continue doing the preprocessing manually, and pass the
/no-preprocessflag to llvm-rc if it is supported.