feat: improve copyWith of ResourceReady and ResourceError

nank1ro · Sep 6, 2023 · f5c2bfc · f5c2bfc
1 parent 939fe30
commit f5c2bfc
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 9 deletions.
diff --git a/packages/flutter_solidart/CHANGELOG.md b/packages/flutter_solidart/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 1.0.1
+
+### Changes from solidart
+
+- **CHORE** Improve `copyWith` methods of `ResourceReady` and `ResourceError`
+
 ## 1.0.0
 
 The core of the library has been rewritten in order to support automatic dependency tracking like SolidJS.

diff --git a/packages/flutter_solidart/pubspec.yaml b/packages/flutter_solidart/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flutter_solidart
 description: A simple State Management solution for Flutter applications inspired by SolidJS
-version: 1.0.0
+version: 1.0.1
 repository: https://github.com/nank1ro/solidart
 documentation: https://docs.page/nank1ro/solidart~dev
 topics:
@@ -16,7 +16,7 @@ dependencies:
   flutter:
     sdk: flutter
   meta: ^1.9.1
-  solidart: ^1.0.0
+  solidart: ^1.0.1
 
 dev_dependencies:
   flutter_test:

diff --git a/packages/solidart/CHANGELOG.md b/packages/solidart/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.0.1
+
+Improve `copyWith` methods of `ResourceReady` and `ResourceError`
+
 ## 1.0.0+4
 
 Fix the pub.dev pub points.

diff --git a/packages/solidart/lib/src/core/resource.dart b/packages/solidart/lib/src/core/resource.dart
@@ -458,12 +458,13 @@ class ResourceReady<T> implements ResourceState<T> {
   @override
   int get hashCode => Object.hash(runtimeType, value, isRefreshing);
 
-  /// Convenience method to update the [isRefreshing] value of a [Resource]
+  /// Convenience method to update the values of a [ResourceReady].
   ResourceReady<T> copyWith({
+    T? value,
     bool? isRefreshing,
   }) {
-    return ResourceReady(
-      value,
+    return ResourceReady<T>(
+      value ?? this.value,
       isRefreshing: isRefreshing ?? this.isRefreshing,
     );
   }
@@ -558,11 +559,13 @@ class ResourceError<T> implements ResourceState<T> {
 
   /// Convenience method to update the [isRefreshing] value of a [Resource]
   ResourceError<T> copyWith({
+    Object? error,
+    StackTrace? stackTrace,
     bool? isRefreshing,
   }) {
-    return ResourceError(
-      error,
-      stackTrace: stackTrace,
+    return ResourceError<T>(
+      error ?? this.error,
+      stackTrace: stackTrace ?? this.stackTrace,
       isRefreshing: isRefreshing ?? this.isRefreshing,
     );
   }

diff --git a/packages/solidart/pubspec.yaml b/packages/solidart/pubspec.yaml
@@ -1,6 +1,6 @@
 name: solidart
 description: A simple State Management solution for Dart applications inspired by SolidJS
-version: 1.0.0+4
+version: 1.0.1
 repository: https://github.com/nank1ro/solidart
 documentation: https://docs.page/nank1ro/solidart~dev
 topics: