Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1 NuGet dependencies #346

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update 1 NuGet dependencies #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nanoFramework.Json.Benchmark/nanoFramework.Json.Benchmark.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
<Reference Include="nanoFramework.Runtime.Native, Version=1.6.12.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Runtime.Native.1.6.12\lib\nanoFramework.Runtime.Native.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Collections, Version=1.5.31.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.31\lib\nanoFramework.System.Collections.dll</HintPath>
<Reference Include="nanoFramework.System.Collections, Version=1.5.45.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.45\lib\nanoFramework.System.Collections.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Text, Version=1.2.54.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Text.1.2.54\lib\nanoFramework.System.Text.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Json.Benchmark/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<package id="nanoFramework.CoreLibrary" version="1.15.5" targetFramework="netnano1.0" />
<package id="nanoFramework.Logging" version="1.1.108" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Native" version="1.6.12" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.31" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.45" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Diagnostics.Stopwatch" version="1.2.628" targetFramework="netnano1.0" />
<package id="nanoFramework.System.IO.Streams" version="1.1.59" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Text" version="1.2.54" targetFramework="netnano1.0" />
Expand Down
6 changes: 3 additions & 3 deletions nanoFramework.Json.Benchmark/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
},
"nanoFramework.System.Collections": {
"type": "Direct",
"requested": "[1.5.31, 1.5.31]",
"resolved": "1.5.31",
"contentHash": "q7G0BHkbhUzpUJiOQNlZZDSMcZEU2/QJBDiSEQAF23wOya4EBaCXS74jAVcEfkHBgOkF413jKZq5vldpjqUfUw=="
"requested": "[1.5.45, 1.5.45]",
"resolved": "1.5.45",
"contentHash": "dil6zTz67ACEboy5aWib+lcK+v5eOdvChow3UoZjPdH/fsHsHl26D6/OmQKp+KPVdi5/59WUM5InFB4F5FEQfQ=="
},
"nanoFramework.System.Diagnostics.Stopwatch": {
"type": "Direct",
Expand Down
4 changes: 2 additions & 2 deletions nanoFramework.Json.Test/nanoFramework.Json.Test.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
<Reference Include="mscorlib">
<HintPath>..\packages\nanoFramework.CoreLibrary.1.15.5\lib\mscorlib.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Collections">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.31\lib\nanoFramework.System.Collections.dll</HintPath>
<Reference Include="nanoFramework.System.Collections, Version=1.5.45.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.45\lib\nanoFramework.System.Collections.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Text">
<HintPath>..\packages\nanoFramework.System.Text.1.2.54\lib\nanoFramework.System.Text.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Json.Test/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="nanoFramework.CoreLibrary" version="1.15.5" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.31" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.45" targetFramework="netnano1.0" />
<package id="nanoFramework.System.IO.Streams" version="1.1.59" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Text" version="1.2.54" targetFramework="netnano1.0" />
<package id="nanoFramework.TestFramework" version="2.1.112" targetFramework="netnano1.0" developmentDependency="true" />
Expand Down
6 changes: 3 additions & 3 deletions nanoFramework.Json.Test/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
},
"nanoFramework.System.Collections": {
"type": "Direct",
"requested": "[1.5.31, 1.5.31]",
"resolved": "1.5.31",
"contentHash": "q7G0BHkbhUzpUJiOQNlZZDSMcZEU2/QJBDiSEQAF23wOya4EBaCXS74jAVcEfkHBgOkF413jKZq5vldpjqUfUw=="
"requested": "[1.5.45, 1.5.45]",
"resolved": "1.5.45",
"contentHash": "dil6zTz67ACEboy5aWib+lcK+v5eOdvChow3UoZjPdH/fsHsHl26D6/OmQKp+KPVdi5/59WUM5InFB4F5FEQfQ=="
Comment on lines +13 to +15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Conflicting versions found for nanoFramework.System.Collections.

Multiple dependencies specify different versions of nanoFramework.System.Collections:

  • nanoFramework.Json.Benchmark/packages.lock.json uses version 1.6.12.
  • nanoFramework.Json.Test/packages.lock.json and nanoFramework.Json/packages.lock.json reference version 1.15.5.

Please ensure all dependencies are aligned to use version 1.5.45 to avoid potential conflicts and maintain compatibility.

🔗 Analysis chain

Verify compatibility with other dependencies and test thoroughly.

While this is a minor version update and should maintain backwards compatibility, it's important to ensure that this change doesn't introduce any unexpected behavior or conflicts with other dependencies.

Please run the project's test suite to verify that all functionality remains intact after this update. Additionally, check the changelog for nanoFramework.System.Collections 1.5.45 to be aware of any changes that might affect your project.

To help with this verification, you can run the following script to check for any potential conflicts:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for potential conflicts or inconsistencies after the update

# Test 1: Check if there are any hardcoded version references to the old version
# Expect: No occurrences of the old version (1.5.31) in the codebase
echo "Checking for hardcoded references to the old version:"
rg "1\.5\.31"

# Test 2: Check if there are any other dependencies that explicitly depend on a different version of nanoFramework.System.Collections
# Expect: No other dependencies should specify a different version
echo "Checking for conflicting dependency versions:"
rg --type json -C 5 '"nanoFramework.System.Collections"' | grep -v '"1.5.45"'

Length of output: 1944

Script:

#!/bin/bash
# Description: Check for potential conflicts or inconsistencies after the update

# Test 1: Check if there are any hardcoded version references to the old version
# Expect: No occurrences of the old version (1.5.31) in the codebase
echo "Checking for hardcoded references to the old version:"
rg "1\.5\.31"

# Test 2: Check if there are any other dependencies that explicitly depend on a different version of nanoFramework.System.Collections
# Expect: No other dependencies should specify a different version
echo "Checking for conflicting dependency versions:"
rg --type json -C 5 '"nanoFramework.System.Collections"' | grep -v '"1\.5\.45"'

Length of output: 2973

},
"nanoFramework.System.IO.Streams": {
"type": "Direct",
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Json.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<tags>nanoFramework C# csharp netmf netnf json</tags>
<dependencies>
<dependency id="nanoFramework.CoreLibrary" version="1.15.5" />
<dependency id="nanoFramework.System.Collections" version="1.5.31" />
<dependency id="nanoFramework.System.Collections" version="1.5.45" />
<dependency id="nanoFramework.System.IO.Streams" version="1.1.59" />
</dependencies>
</metadata>
Expand Down
4 changes: 2 additions & 2 deletions nanoFramework.Json/nanoFramework.Json.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
<Reference Include="mscorlib, Version=1.15.6.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.CoreLibrary.1.15.5\lib\mscorlib.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Collections, Version=1.5.31.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.31\lib\nanoFramework.System.Collections.dll</HintPath>
<Reference Include="nanoFramework.System.Collections, Version=1.5.45.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.45\lib\nanoFramework.System.Collections.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Text, Version=1.2.54.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Text.1.2.54\lib\nanoFramework.System.Text.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Json/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="nanoFramework.CoreLibrary" version="1.15.5" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.31" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.45" targetFramework="netnano1.0" />
<package id="nanoFramework.System.IO.Streams" version="1.1.59" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Text" version="1.2.54" targetFramework="netnano1.0" />
<package id="Nerdbank.GitVersioning" version="3.6.143" targetFramework="netnano1.0" developmentDependency="true" />
Expand Down
6 changes: 3 additions & 3 deletions nanoFramework.Json/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
},
"nanoFramework.System.Collections": {
"type": "Direct",
"requested": "[1.5.31, 1.5.31]",
"resolved": "1.5.31",
"contentHash": "q7G0BHkbhUzpUJiOQNlZZDSMcZEU2/QJBDiSEQAF23wOya4EBaCXS74jAVcEfkHBgOkF413jKZq5vldpjqUfUw=="
"requested": "[1.5.45, 1.5.45]",
"resolved": "1.5.45",
"contentHash": "dil6zTz67ACEboy5aWib+lcK+v5eOdvChow3UoZjPdH/fsHsHl26D6/OmQKp+KPVdi5/59WUM5InFB4F5FEQfQ=="
},
"nanoFramework.System.IO.Streams": {
"type": "Direct",
Expand Down