-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ASSERT in GC heap compact #3058
Conversation
- Add code to handle edge cases that could run into buffer access issues in odd cases. - Remove ShiftBufferToLeft as it wasn't adding any value to the code, actually making it hard to read.
- Addressing potential issues with heap compaction execution.
…into skyworks-evb
- Update nano implementation of Gecko SPI. - Port back code from Gecko SDK. - Update declarations.
- Now processing return result and throwing exception with encoded error code on failure. - Update declaration of ThrowError function.
…into skyworks-evb
- Fix compiler define conditional. - Fix assert for move size.
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 198 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist