Skip to content

Commit

Permalink
Change colons for Modifier Letter Triangular Colon
Browse files Browse the repository at this point in the history 
#301 Homekit has special rules for naming items. They must start with an alpha or numeric value, then they can contain alphanumeric characters, space and apostrophe, and they must end with an alpha or numeric character. The created sensors are using colons for delimiters, which isn't allowed. However, according to Apple documentation alphanumeric characters consist of Unicode character sets L*, M* and N*. The Modifier Letter Triangular Colon falls into the L* set, so it should be legal to use.
See homebridge/HAP-NodeJS#1079 for more detail.
  • Loading branch information
@dacarson
dacarson committed Dec 11, 2024
1 parent 276167e commit 53d3350
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ WeatherPlusPlatform.prototype = {
{
accessory.AirPressureService.setCharacteristic(Characteristic.OccupancyDetected, convertedValue >= config.thresholdAirPressure);
}
accessory.AirPressureService.setCharacteristic(Characteristic.ConfiguredName, "Air Pressure: " + convertedValue + " " + accessory.AirPressureService.unit);
accessory.AirPressureService.setCharacteristic(Characteristic.Name, "Air Pressure: " + convertedValue + " " + accessory.AirPressureService.unit);
accessory.AirPressureService.setCharacteristic(Characteristic.ConfiguredName, "Air Pressureː " + convertedValue + " " + accessory.AirPressureService.unit);
accessory.AirPressureService.setCharacteristic(Characteristic.Name, "Air Pressureː " + convertedValue + " " + accessory.AirPressureService.unit);
accessory.AirPressureService.value = convertedValue; // Save value to use in history
}
else if (name === "CloudCover")
Expand All @@ -368,8 +368,8 @@ WeatherPlusPlatform.prototype = {
{
accessory.CloudCoverService.setCharacteristic(Characteristic.OccupancyDetected, convertedValue >= config.thresholdCloudCover);
}
accessory.CloudCoverService.setCharacteristic(Characteristic.ConfiguredName, "Cloud Cover: " + convertedValue);
accessory.CloudCoverService.setCharacteristic(Characteristic.Name, "Cloud Cover: " + convertedValue);
accessory.CloudCoverService.setCharacteristic(Characteristic.ConfiguredName, "Cloud Coverː " + convertedValue);
accessory.CloudCoverService.setCharacteristic(Characteristic.Name, "Cloud Coverː " + convertedValue);
}
else if (name === "DewPoint")
{
Expand Down Expand Up @@ -405,18 +405,18 @@ WeatherPlusPlatform.prototype = {
{
accessory.UVIndexService.setCharacteristic(Characteristic.OccupancyDetected, convertedValue >= config.thresholdUvIndex);
}
accessory.UVIndexService.setCharacteristic(Characteristic.ConfiguredName, "UV Index: " + convertedValue);
accessory.UVIndexService.setCharacteristic(Characteristic.Name, "UV Index: " + convertedValue);
accessory.UVIndexService.setCharacteristic(Characteristic.ConfiguredName, "UV Indexː " + convertedValue);
accessory.UVIndexService.setCharacteristic(Characteristic.Name, "UV Indexː " + convertedValue);
}
else if (name === "Visibility")
{
accessory.VisibilityService.setCharacteristic(Characteristic.ConfiguredName, "Visibility: " + convertedValue + " " + accessory.VisibilityService.unit);
accessory.VisibilityService.setCharacteristic(Characteristic.Name, "Visibility: " + convertedValue + " " + accessory.VisibilityService.unit);
accessory.VisibilityService.setCharacteristic(Characteristic.ConfiguredName, "Visibilityː " + convertedValue + " " + accessory.VisibilityService.unit);
accessory.VisibilityService.setCharacteristic(Characteristic.Name, "Visibilityː " + convertedValue + " " + accessory.VisibilityService.unit);
}
else if (name === "WindDirection")
{
accessory.WindDirectionService.setCharacteristic(Characteristic.ConfiguredName, "Wind Dir: " + convertedValue);
accessory.WindDirectionService.setCharacteristic(Characteristic.Name, "Wind Dir: " + convertedValue);
accessory.WindDirectionService.setCharacteristic(Characteristic.ConfiguredName, "Wind Dirː " + convertedValue);
accessory.WindDirectionService.setCharacteristic(Characteristic.Name, "Wind Dirː " + convertedValue);
}
else if (name === "WindSpeed")
{
Expand All @@ -428,13 +428,13 @@ WeatherPlusPlatform.prototype = {
{
accessory.WindSpeedService.setCharacteristic(Characteristic.OccupancyDetected, convertedValue >= config.thresholdWindSpeed);
}
accessory.WindSpeedService.setCharacteristic(Characteristic.ConfiguredName, "Wind Speed: " + convertedValue + " " + accessory.WindSpeedService.unit);
accessory.WindSpeedService.setCharacteristic(Characteristic.Name, "Wind Speed: " + convertedValue + " " + accessory.WindSpeedService.unit);
accessory.WindSpeedService.setCharacteristic(Characteristic.ConfiguredName, "Wind Speedː " + convertedValue + " " + accessory.WindSpeedService.unit);
accessory.WindSpeedService.setCharacteristic(Characteristic.Name, "Wind Speedː " + convertedValue + " " + accessory.WindSpeedService.unit);
}
else if(name === "RainDay") {
accessory.RainDayService.setCharacteristic(Characteristic.OccupancyDetected, value > 0);
accessory.RainDayService.setCharacteristic(Characteristic.ConfiguredName, "Total Precip: " + convertedValue + " " + accessory.RainDayService.unit);
accessory.RainDayService.setCharacteristic(Characteristic.Name, "Total Precip: " + convertedValue + " " + accessory.RainDayService.unit);
accessory.RainDayService.setCharacteristic(Characteristic.ConfiguredName, "Total Precipː " + convertedValue + " " + accessory.RainDayService.unit);
accessory.RainDayService.setCharacteristic(Characteristic.Name, "Total Precipː " + convertedValue + " " + accessory.RainDayService.unit);
}
else
{
Expand Down

0 comments on commit 53d3350

Please sign in to comment.