Environment Support #25
Conversation
|
I'm not sure if anyone can authorise the changes? Would be nice to get this added as i have a whole environment with 2930 switches. |
|
Hi @N0odlez, Thanks for your contribution. Could you add unit tests for the new method? -> https://github.com/napalm-automation-community/napalm-arubaos-switch/tree/development/test |
|
Hi @gcotone, I've added unit tests and also squashed to one commit. |
| member = switch.pop("member") | ||
| if member == "": | ||
| member = 0 | ||
| else: | ||
| member = "Member " + member | ||
|
|
||
| out["cpu"][member] = { | ||
| "%usage": float(switch.pop("cpu")) | ||
| } | ||
|
|
||
| memtotal += int(switch.pop("memtotal").replace(',', '')) | ||
| memfree += int(switch.pop("memfree").replace(',', '')) |
There was a problem hiding this comment.
Is there any reason for using pop() to fetch the values from ephemeral dicts? the more natural choice should be get()
| return super(ArubaOSS, self).get_users() | ||
| return get_users() |
There was a problem hiding this comment.
Is this coming from a different change? seems unrelated to the PR.
| memtotal += int(switch.pop("memtotal").replace(',', '')) | ||
| memfree += int(switch.pop("memfree").replace(',', '')) |
There was a problem hiding this comment.
Is the increment for the stack switches use-case ? If that's the case I think it's probably better to report back the memory of the device running the control-plane/primary-switch instead of the sum of the whole stack.
Added Environment support
Description
Added support for Environment. Tested with 2930F and 2930M standalone and 2030M in a stack
Types of Changes
What types of changes does your code introduce? Keep the ones that apply: