-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the docs napari dependency groups (docs, gallery) & add to contributing guide #589
Comments
So with those dependencies in napari/napari, it means the napari clone/install needs to use them. Line 24 in 0c066aa
|
@jni missed some requirements, so this depends on: napari/napari#7637 |
# References and relevant issues Part of: napari/docs#589 # Description In #7487 a few requirements were missed. This PR adds them back. I also update the `_docs` constraints -- not for any of the new versions (leave that to the normal PR), just for docs. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
I'm thinking:
Any thoughts @melissawm @jni ? |
# References and relevant issues Part of: napari/docs#589 Depends on: napari/docs#591 # Description This PR updates the build_docs.yml action to match napari/docs. It's somewhat unneeded, because it ~fires off merge to main~ fires off of `v*` tag push, while we build/deploy docs from napari/docs, but it can be manually triggered, so it should be correct.
…groups (#590) # References and relevant issues Part of addressing: #589 Depends on: napari/napari#7637 # Description Instead of using the `docs-install` make step, this installs napari with the `docs` and `gallery` dependency groups. Also, switch to using PyQT5 to make things less flaky. Note: our main build and deploy workflow has always been using pyqt5, so now CircleCI matches what is deployed.
This looks like a good plan to me. I will try to get up to speed on the recent changes and report back if I see anything missing. |
# References and relevant issues Part of: #589 Depends on: napari/napari#7637 # Description Installs napari with `[docs]` and then doesn't run the `docs-install` step of the Makefile.
I don't think we need to remove html. It will be redundant with docs but it would disrupt some workflows for little gain. In the future, we may want to support other sphinx builds such as pdf. So maybe docs just depends on html? Minor thing: maybe we don't include clean in the html/docs build? If one wants a clean build, they can write
I don't understand this — docs should be rebuilt when we merge to napari main? |
if we remove
Docs are rebuilt on merge to main, but by the action triggered in this repo, not the napari/napari repo. So that action only really functions to be manually triggered, as an alternative to the circleCI builds on PR -- which is fine. |
🧰 Task
Added in napari/napari#7487
The text was updated successfully, but these errors were encountered: