Update CircleCI config.yml to use napari docs and gallery dependency groups #590
Conversation
psobolewskiPhD
changed the title
|
OK with napari/napari#7637 merged I'm trying to re-run CI. |
|
Ok, so now we need napari/napari#7636 to fix the seg fault. |
…tch napari/docs) (#7638) # References and relevant issues This PR matches napari/docs PR: napari/docs#590 # Description Updates the CircleCI action to use the new `docs` dependency group and also switches to using PyQt5 to reduce flakiness. Note: our main build and deploy workflow has always been using pyqt5, so now CircleCI matches what is deployed.
| @@ -32,15 +32,15 @@ jobs: | |||
| name: Install napari-dev | |||
| command: | | |||
| . venv/bin/activate | |||
| python -m pip install -e "napari/[pyside,dev]" | |||
| python -m pip install -e "napari/[pyqt5,docs]" | |||
There was a problem hiding this comment.
Do you still need dev as well?
There was a problem hiding this comment.
I don't think so?
Honestly, we have so many dependency groups that I'm not sure anymore!
|
The build and deploy should be fixed by #591 |
There was a problem hiding this comment.
Love it! Thanks @psobolewskiPhD - I'm not sure how the pyqt issue was resolved in circleci though (we were using pyside for a good reason but I confess I don't remember anymore)
|
@melissawm Can you restart CI to see if the build for the latest PR will run cleanly? TYVM. |
|
Sorry @willingc how do I do that? |
|
@melissawm no worries, juan did it. Usually you can go to the github actions page and choose the restart option on the top right corner. |
|
Oh I see, I thought this was related to the CircleCI issue we discussed before (some people appear to not have access to it) |
References and relevant issues
Part of addressing: #589
Depends on: napari/napari#7637
Description
Instead of using the
docs-installmake step, this installs napari with thedocsandgallerydependency groups.Also, switch to using PyQT5 to make things less flaky.
Note: our main build and deploy workflow has always been using pyqt5, so now CircleCI matches what is deployed.