Bugfix: Use importlib.metadata.version instead import from _version #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jni
approved these changes
Nov 27, 2023
psobolewskiPhD
added
the
ready-to-merge
psobolewskiPhD
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #177
In this PR I get the napari version using importlib.metadata.version instead of importing from _version.
In older napari versions the variable name was different, resulting in the error shown in #177
This method should be backwards compatible for any napari on python >= 3.8
To be safe for older python also try importlib_metadata but if that doesn't work, then just note the version as older than 0.4.15, the first version to not support python 3.7.