Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips for Import/export buttons and clarify file format #127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

psobolewskiPhD
Copy link
Member

In this PR I add simple tooltips to the buttons, just so it's clear from the UI what these do.
Also, I was curious what the file format is like, so I added that to the docs.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (34d3fa9) to head (34e3303).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          13       13           
  Lines        2099     2099           
=======================================
  Hits         1975     1975           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@TimMonko TimMonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarifications. Might be worth adding a mention of import using pip only (I think thats how I understand the code)

@psobolewskiPhD
Copy link
Member Author

import using pip only

I don't think so?
Looks like it calls install_packages which checks the tool to use:

def _install_packages(
self,
packages: Sequence[str] = (),
):
if not packages:
_packages = self.direct_entry_edit.text()
packages = (
[_packages] if os.path.exists(_packages) else _packages.split()
)
self.direct_entry_edit.clear()
if packages:
tool = (
InstallerTools.CONDA
if self._action_conda.isChecked()
else InstallerTools.PIP
)
self.installer.install(tool, packages)

@TimMonko
Copy link

Yes, I goofed. I was thinking I can't install from conda with pip, forgetting I can't test conda without a conda install. I read the code wrong. I shouldn't have hit approve, just comment that it was a good idea to clarify. I was just browsing around, sorry! Still learning how to be helpful.

README.md Outdated Show resolved Hide resolved
@goanpeca
Copy link
Contributor

Thanks for working on this @psobolewskiPhD :)

Co-authored-by: Tim Monko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants