-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips for Import/export buttons and clarify file format #127
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 13 13
Lines 2099 2099
=======================================
Hits 1975 1975
Misses 124 124 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good clarifications. Might be worth adding a mention of import using pip only (I think thats how I understand the code)
I don't think so? napari-plugin-manager/napari_plugin_manager/base_qt_plugin_dialog.py Lines 1590 to 1607 in 34d3fa9
|
Yes, I goofed. I was thinking I can't install from conda with pip, forgetting I can't test conda without a conda install. I read the code wrong. I shouldn't have hit approve, just comment that it was a good idea to clarify. I was just browsing around, sorry! Still learning how to be helpful. |
Thanks for working on this @psobolewskiPhD :) |
Co-authored-by: Tim Monko <[email protected]>
In this PR I add simple tooltips to the buttons, just so it's clear from the UI what these do.
Also, I was curious what the file format is like, so I added that to the docs.