Use display name on plugins that provide it

[goanpeca]

References and relevant issues

• Part of Plugin dialog requests #14
• Needs the following PR Add extra field to store plugin display name napari#6841
• Needs Move qss file from napari to plugin manager #43

Description

This PR now displays the display name (if provided by author) on the available plugins list. The installed list still will not show them as another fix needs to be carried out on the npe2 project to include the extra field in the metadata.

Search works for both package name and display name

Screenshot

Before

After this PR

[jaimergp]

How does this relate to #15?

[goanpeca]

@jaimergp #15 was a stale PR, this one superseeds it!

[Czaki]

looks ok for me

[jaimergp]

Since we don't disambiguate on display names (the uniqueness is only guaranteed for the actual package name), this could be used to inject malicious packages in the ecosystem.

I suggest the actual package name is also shown next to the display name, or at least provide an icon with a tooltip listing the actual name.

[Czaki]

Since we don't disambiguate on display names (the uniqueness is only guaranteed for the actual package name), this could be used to inject malicious packages in the ecosystem.

good point. I think we should always show name of package, as people may not check tooltip. We should also highlight collisions somehow.

[goanpeca]

Thanks for the comments, I will add the name next to the display name !

Since the Package name is a QPushButton it cannot have rich text added to it to display the package name smaller or in italics or something different.

Would something like this work @jaimergp @Czaki ?

[goanpeca]

We should also highlight collisions somehow.

As in 2 packages are using the same display name?

Sounds like something to be addressed separately? 🤔

[Czaki]

@goanpeca did you point example package with, a different package name and display name?

[goanpeca]

@goanpeca did you point example package with, a different package name and display name?

@Czaki yes, in the example above: Display Name is Cut Detector, and package name is cut-detector. Apologies I was not more explicit :)

[Czaki]

I missed it (on image) will test it tomorrow.

[jaimergp]

Any updates here?

[Czaki]

In line 404 we get plugin name from button text, that will not work with rich name.

Why can we not change button into label? As far as I check we only use it to open project website, that could be done with link on QLabel.

[goanpeca]

Why can we not change button into label? As far as I check we only use it to open project website, that could be done with link on QLabel.

You are correct, working on a prototype

[goanpeca]

This uses now a clickable label to preserve the previous behavior. Also styling of links inside rich texts is not possible, so this also preserves the UI look in general

Example on image

Display name: napari ARCOS
plugin name: arcos-gui

What do you think @Czaki, @jaimergp, @psobolewskiPhD ?

Also, I needed to change some QSS that lives on napari side. I am bringing this over on a separate PR

[goanpeca]

This was failing with missing wheels due to latest being arm I think?

[goanpeca]

The same error was being seen across the board

Soma variation of object cannot be interpreted as an integer

Following napari I am only testing pyside2 combination for linux with python 3.9 and 3.10