Move npe2api.py from napari repo to this repo #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
changed the title
Changes the plugin dialog to match the design discussed in #4952 Co-authored-by: Draga Doncila Pop <[email protected]> Co-authored-by: Gonzalo Pena-Castellanos <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Grzegorz Bokota <[email protected]> Co-authored-by: Daniel Althviz Moré <[email protected]> Co-authored-by: Peter Sobolewski <[email protected]>
# Fixes/Closes <!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5724 # Description <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> # References <!-- What resources, documentation, and guides were used in the creation of this PR? --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [ ] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
# Fixes/Closes Closes napari/napari#5506 # Description The Briefcase bundles have not been working for a while (at least in some platforms), nobody is testing them either, and our development efforts are mostly directed to the `constructor` installers. In this PR, they are removed to [avoid CI waste](napari/napari#5660) and permit deleting some strange code paths for Briefcase workarounds. # References ## Type of change - [X] Removes / deprecates code # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] No CI jobs for Briefcase - [x] Tests pass without the extra Briefcase workarounds ## Final checklist: - [X] My PR is the minimum possible work for the desired functionality - [x] I have made corresponding changes to the documentation: napari/docs#147 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Grzegorz Bokota <[email protected]>
Step toward #2751 Start taking mypy errors one by one and fix/ignore them. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wouter-Michiel Vierdag <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.1.9 → v0.1.11](astral-sh/ruff-pre-commit@v0.1.9...v0.1.11) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Grzegorz Bokota <[email protected]>
# Description Based on a discussion from #6386 I updated the ruff configuration to enable `Q000` https://docs.astral.sh/ruff/rules/#flake8-quotes-q rule and configured it to use a single quotes string. We have many double quotes string, but less than single quotes. This PR does not change the quotation of docstrings (`"""`) and multiline strings (`"""`) as they are already enforced by ruff configuration and could be easy changed. to see configuration changes please use: napari/napari@a422ad7 cc @jni @brisvag --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
# Description Drop python 3.8 start testing on python 3.12 * Disable PySide6 for python 3.12 (need #6062) * Workflows updated with new versions, by bumping each python version by 1 (as well as project and tox.ini) * a couple of "if version < 3.9" checks removed * Change List and Tuple to list and tuple in type annotation (part of them automatically) Also, automatically by pre-commit * a couple of parenthesized context managers * change to import from `collections` instead of `typing` for a bunch of types (like `Sequence`) * import part of things from `typing` instead of `typing_extension` (like `Annotated`). * one lru_cache to cache --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Grzegorz Bokota <[email protected]>
…d resolve pointed problems. (#6866) Updated packages: `filelock`, `hypothesis`, `pyproject-hooks`, `pytest`, `virtualenv` Fix workflow for bumping mypy constraints and manual bump them, then resolve new pointed bugs. --------- Co-authored-by: napari-bot <[email protected]> Co-authored-by: Grzegorz Bokota <[email protected]>
…ng the plugin manager (#6931) Fixes napari#26 # Description Catches connectivity errors when fetching for plugin information when opening the plugin manager. Although the issue lives in the plugin manager repo, the code that fetches the code still lives in napari, hence with the PR seem to be better resolved on this side. # Result ## Before this PR  ## With this PR  The warning reads: >There seems to be an issue with network connectivity. Remote plugins cannot be installed, only local ones.
jaimergp
reviewed
May 28, 2024
| from npe2 import PackageMetadata | ||
| from typing_extensions import NotRequired | ||
|
|
||
| PyPIname = str |
There was a problem hiding this comment.
Suggested change
| PyPIname = str | |
| PyPIName = str |
I'd normally type it like that but it looks weird :/
jaimergp
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #33
Move
npe2api.pyfrom napari repo file with history and adapt code in this repo to use that file directly.Requires #40 to solve failing tests