Support RGB images by using only first two elems of image shape #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes now only the width and height of the image to calculate the extrema. This avoids an error when using color images
jni
approved these changes
Jan 10, 2025
|
@Micro-Sandworms nice, thanks! Have you verified that this correctly saves RGB images? (I haven't checked whether the rest of the code supports writing RGB images correctly.) |
jni
changed the title
Merged
|
@Micro-Sandworms thanks for your contribution, which actually helped me fix a pretty major bug in image writing since 0.2.0! This fix and #52 are now released as 0.2.1! 🥳 |
|
Thank you, Juan. I am happy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes now only the width and height of the image to calculate the extrema. This avoids an error when using color images