ci: trigger slow downstream libraries tests suites before release (#1321

) Co-authored-by: Francesco Bruzzesi <[email protected]> --------- Co-authored-by: Francesco Bruzzesi <[email protected]>
narwhals-dev · Nov 7, 2024 · 1f3f460 · 1f3f460
1 parent 943786e
commit 1f3f460
Show file tree

Hide file tree

Showing 3 changed files with 73 additions and 62 deletions.
diff --git a/.github/workflows/downstream_tests.yml b/.github/workflows/downstream_tests.yml
@@ -1,4 +1,4 @@
-name: Test Downstream Libraries
+name: Test Downstream Libraries - Fast
 
 on: 
   pull_request:
@@ -230,60 +230,3 @@ jobs:
         run: |
             cd tubular
             pytest tests --config-file=pyproject.toml
-  
-  # vegafusion:
-  #    env:
-  #      UV_SYSTEM_PYTHON: true
-
-  #    strategy:
-  #      matrix:
-  #        python-version: ["3.11"]
-  #        os: [ubuntu-latest]
-
-  #    runs-on: ${{ matrix.os }}
-  #    steps:
-  #       - uses: actions/checkout@v4
-  #       - uses: actions/setup-python@v5
-  #         with:
-  #           python-version: ${{ matrix.python-version }}
-  #       - name: Install uv
-  #         uses: astral-sh/setup-uv@v3
-  #         with:
-  #           enable-cache: "true"
-  #           cache-suffix: ${{ matrix.python-version }}
-  #           cache-dependency-glob: "**requirements*.txt"
-  #       - name: clone-vegafusion
-  #         run: |
-  #             git clone --single-branch -b v2 https://github.com/vega/vegafusion.git
-  #             cd vegafusion
-  #             git log
-  #       - name: Cache rust dependencies
-  #         uses: Swatinem/rust-cache@v2
-  #         with:
-  #           workspaces: vegafusion
-  #       - name: Build wheels
-  #         uses: PyO3/maturin-action@v1
-  #         with:
-  #           command: build
-  #           manylinux: 2014
-  #           rust-toolchain: stable
-  #           args: --release -m vegafusion/vegafusion-python/Cargo.toml --features=protobuf-src --strip
-  #       - name: Install wheels
-  #         working-directory: vegafusion/target/wheels/
-  #         run: |
-  #           ls -la
-  #           python -m pip install vegafusion-*manylinux*.whl
-
-  #           # Optional dependencies
-  #           python -m pip install pyarrow pandas polars-lts-cpu "duckdb>=1.0" "vl-convert-python>=1.0.1rc1" scikit-image "pandas>=2.2" jupytext voila anywidget ipywidgets chromedriver-binary-auto
-
-  #           # Test dependencies
-  #           python -m pip install pytest altair vega-datasets scikit-image jupytext voila ipykernel anywidget ipywidgets selenium flaky tenacity chromedriver-binary-auto 
-  #       - name: Test lazy imports
-  #         working-directory: vegafusion/vegafusion-python/
-  #         run: python checks/check_lazy_imports.py
-  #       - name: Test vegafusion
-  #         working-directory: vegafusion/vegafusion-python/
-  #         env:
-  #           VEGAFUSION_TEST_HEADLESS: 1
-  #         run: pytest
diff --git a/.github/workflows/downstream_tests_slow.yml b/.github/workflows/downstream_tests_slow.yml
@@ -0,0 +1,63 @@
+name: Test Downstream Libraries - Slow
+
+on: 
+  workflow_call:
+  workflow_dispatch:
+
+jobs:
+  vegafusion:
+     env:
+       UV_SYSTEM_PYTHON: true
+
+     strategy:
+       matrix:
+         python-version: ["3.11"]
+         os: [ubuntu-latest]
+
+     runs-on: ${{ matrix.os }}
+     steps:
+        - uses: actions/checkout@v4
+        - uses: actions/setup-python@v5
+          with:
+            python-version: ${{ matrix.python-version }}
+        - name: Install uv
+          uses: astral-sh/setup-uv@v3
+          with:
+            enable-cache: "true"
+            cache-suffix: ${{ matrix.python-version }}
+            cache-dependency-glob: "**requirements*.txt"
+        - name: clone-vegafusion
+          run: |
+              git clone --single-branch -b v2 https://github.com/vega/vegafusion.git
+              cd vegafusion
+              git log
+        - name: Cache rust dependencies
+          uses: Swatinem/rust-cache@v2
+          with:
+            workspaces: vegafusion
+        - name: Build wheels
+          uses: PyO3/maturin-action@v1
+          with:
+            command: build
+            manylinux: 2014
+            rust-toolchain: stable
+            args: --release -m vegafusion/vegafusion-python/Cargo.toml --features=protobuf-src --strip
+        - name: Install wheels
+          working-directory: vegafusion/target/wheels/
+          run: |
+            ls -la
+            python -m pip install vegafusion-*manylinux*.whl
+
+            # Optional dependencies
+            python -m pip install pyarrow pandas polars-lts-cpu "duckdb>=1.0" "vl-convert-python>=1.0.1rc1" scikit-image "pandas>=2.2" jupytext voila anywidget ipywidgets chromedriver-binary-auto
+
+            # Test dependencies
+            python -m pip install pytest altair vega-datasets scikit-image jupytext voila ipykernel anywidget ipywidgets selenium flaky tenacity chromedriver-binary-auto 
+        - name: Test lazy imports
+          working-directory: vegafusion/vegafusion-python/
+          run: python checks/check_lazy_imports.py
+        - name: Test vegafusion
+          working-directory: vegafusion/vegafusion-python/
+          env:
+            VEGAFUSION_TEST_HEADLESS: 1
+          run: pytest
diff --git a/.github/workflows/publish_to_pypi.yml b/.github/workflows/publish_to_pypi.yml
@@ -1,11 +1,18 @@
 name: Publish Python 🐍 distribution 📦 to PyPI and TestPyPI
 
-on: push
+on: 
+  push:
+    tags:
+      - "v[0-9]+.[0-9]+.[0-9]+*"
 
 
 jobs:
+  slow-downstream-tests:
+    uses: ./.github/workflows/downstream_tests_slow.yml
+
   build:
     name: Build distribution 📦
+    needs: slow-downstream-tests
     runs-on: ubuntu-latest
 
     steps:
@@ -29,9 +36,7 @@ jobs:
         path: dist/
 
   publish-to-pypi:
-    name: >-
-      Publish Python 🐍 distribution 📦 to PyPI
-    if: startsWith(github.ref, 'refs/tags/v')  # only publish to PyPI on tag pushes
+    name: Publish Python 🐍 distribution 📦 to PyPI
     needs:
     - build
     runs-on: ubuntu-latest