fill_null include type

narwhals-dev · Jul 19, 2024 · 8dd7815 · 8dd7815
1 parent d863827
commit 8dd7815
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/narwhals/_arrow/series.py b/narwhals/_arrow/series.py
@@ -315,8 +315,12 @@ def sample(
         return self._from_native_series(pc.take(ser, mask))
 
     def fill_null(self: Self, value: Any) -> Self:
+        pa = get_pyarrow()
         pc = get_pyarrow_compute()
-        return self._from_native_series(pc.fill_null(self._native_series, value))
+        ser = self._native_series
+        dtype = ser.type
+
+        return self._from_native_series(pc.fill_null(ser, pa.scalar(value, dtype)))
 
     @property
     def shape(self) -> tuple[int]: