Skip to content

Commit

Permalink
fix: remove TODO in PandasLikeDataFrame.to_dict (#1352)
Browse files Browse the repository at this point in the history
* fix: TODO to_dict for pandaslike

* merge main and fix doctest fmt
  • Loading branch information
FBruzzesi authored Nov 12, 2024
1 parent f1102da commit dc4ed28
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion narwhals/_pandas_like/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,6 @@ def to_dict(self, *, as_series: bool = False) -> dict[str, Any]:
from narwhals._pandas_like.series import PandasLikeSeries

if as_series:
# TODO(Unassigned): should this return narwhals series?
return {
col: PandasLikeSeries(
self._native_frame[col],
Expand Down

0 comments on commit dc4ed28

Please sign in to comment.