-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native
property and deprecate .to_native()
method
#1301
base: main
Are you sure you want to change the base?
Conversation
nice!
|
I updated accordingly, let me leave a couple of comments:
I replaced only the cases for
I added this, and tested as well. Yet, since it is a free operation, I don't think it is a big drawback keeping it. I personally like the
ππΌ |
My understanding is that CI is failing because all the imports in stable v1 docstrings changed + import narwhals as nw
- import narwhals.stable.v1 as nw how's that the case? |
thanks!
π€ maybe we can bikeshed on this longer then π longterm I think it'd be better to stabilise on a single api...on the one hand, I like the symmetry of to/from, but on the other hand, I do like that |
sorry yeah this was in #1278 |
Just to be sure, was this intended? |
CI looks like it's green now, I think the only failure is because of deprecation warnings having changed in py13, looking into it |
Found the doctest that was raising, I changed it to call |
native
propertynative
property and depredate .to_native()
method
native
property and depredate .to_native()
methodnative
property and deprecate .to_native()
method
thanks!
shall we sleep on this one a bit longer then? i don't feel super-strongly about this one tbh, happy to keep |
Would it be bad to introduce |
I also don't have a strong preference. We could keep it as alias for now, and move the discussion to an issue. In the meantime, we can suggest |
maybe this can be a good topic for discussion for tomorrow's community call? |
What type of PR is this? (check all applicable)
Related issues
DataFrame.native
/LazyFrame.native
/Series.native
propertiesΒ #1295Checklist
If you have comments or can explain your changes, please do so below.