Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed-offset datetime weren't being parsed #1303

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Nov 2, 2024

closes #1302

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@github-actions github-actions bot added the fix label Nov 2, 2024
@MarcoGorelli MarcoGorelli changed the title fix: np.datetime64(..., 'ns') was returning int instead of datetime in to_py_scalar, fixed-offset datetime weren't being parsed fix: fixed-offset datetime weren't being parsed Nov 2, 2024
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL re.VERBOSE flag! This is so useful holy moly!

Thanks for fixing it @MarcoGorelli πŸš€

NarwhalsKittyGIF

@MarcoGorelli MarcoGorelli merged commit 8763535 into narwhals-dev:main Nov 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: fixedoffset time zone results in Unknown Narwhals dtype
2 participants