perf: simplify pandas-like with_columns
#1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
with_columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we no longer need the specialised path, I think https://github.com/narwhals-dev/narwhals/pull/1201/files may have made it redundant
This should address the fragmentation warning noticed in Nixtla/hierarchicalforecast#305
This passes all unit and downstream tests. I also ran the scikit-lego test suite manually locally to make sure (as it was there that we noticed the need for a separate path), and can confirm it still passes
If anyone's reviewing, this is much easier to review hiding whitespace https://github.com/narwhals-dev/narwhals/pull/1366/files?diff=unified&w=1
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.