-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate duplicate column names in pyarrow and duckdb #1815
feat: validate duplicate column names in pyarrow and duckdb #1815
Conversation
Thanks! I'll check the perf impact here in case it's significant |
Thinking about this (also in the pandas case), we could add a flag to |
yes, we may need |
β¦ated_column_names
β¦ated_column_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @IsaiasGutierrezCruz ! i just added a commit to elide the checks in some cases
@MarcoGorelli Thanks for taking care of this PR! Appreciate you getting it over the finish line. |
closes #1920
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
To test the validations, I added three methods in the file tests/frame/schema_test.py. @MarcoGorelli, if you think these would be more appropriate in another file, please feel free to let me know. Additionally, I had to add duckdb as a dependency to the extreme GitHub Actions workflow to accommodate these tests.