Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fill in missing docstrings for GroupBy.agg #215

Merged

Conversation

natmokval
Copy link
Contributor

xref #71

@@ -28,6 +28,7 @@ nav:
- api-reference/dtypes.md
- api-reference/dependencies.md
- api-reference/selectors.md
- api-reference/group_by.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should order these alphabetically.. ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah maybe - we can do it in a separate PR though, it's currently all over the place 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the comment. I sorted alphabetically API Reference and submitted PR #245

@DeaMariaLeon
Copy link
Member

Thank you @natmokval, it's nice! .. but I did have a question so I leave it to @MarcoGorelli ?

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks @natmokval !

narwhals/group_by.py Outdated Show resolved Hide resolved
@MarcoGorelli MarcoGorelli merged commit 21ea816 into narwhals-dev:main May 27, 2024
13 checks passed
@natmokval natmokval mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants