clean: (partial) factor test_common
#482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Jul 10, 2024
Comment on lines
+22
to
+25
| if constructor_with_pyarrow.__name__.startswith("pandas"): | ||
| expected = constructor_with_pyarrow(data) | ||
| else: | ||
| expected = pd.DataFrame(data) |
There was a problem hiding this comment.
I am not too happy with this, but asserting_frame_equal clearly takes the backend into consideration.
Alternative would be to just check for values
There was a problem hiding this comment.
looks good, not sure what else we can do here
FBruzzesi
commented
Jul 10, 2024
Comment on lines
+11
to
+16
| data = {"a": [1, 3, 2], "b": [4, 4, 6], "z": [7.1, 8, 9]} | ||
| df_raw = constructor(data) | ||
| result = nw.from_native(df_raw, eager_only=True).to_numpy() | ||
|
|
||
| expected = np.array([[1, 3, 2], [4, 4, 6], [7.1, 8, 9]]).T | ||
| np.testing.assert_array_equal(result, expected) |
There was a problem hiding this comment.
pandas_nullable and pandas_pyarrow will convert 7.0 to integer, therefore the type check fails. Using 7.1 fixes that
FBruzzesi
changed the title
test_commontest_common
MarcoGorelli
approved these changes
Jul 10, 2024
Comment on lines
+13
to
+16
| @pytest.mark.skipif( | ||
| parse_version(pd.__version__) < parse_version("2.0.0"), | ||
| reason="too old for pandas-pyarrow", | ||
| ) |
There was a problem hiding this comment.
maybe we should be using request and only skipping the elements of constructor where this fails...but ok for a follow-up
Comment on lines
+22
to
+25
| if constructor_with_pyarrow.__name__.startswith("pandas"): | ||
| expected = constructor_with_pyarrow(data) | ||
| else: | ||
| expected = pd.DataFrame(data) |
There was a problem hiding this comment.
looks good, not sure what else we can do here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
test_common.py#401Checklist
If you have comments or can explain your changes, please do so below.
Unsure how to handle
to_pandasandto_numpyfailures