feat: add year, month, day, hour, minute, second, millisecond, micros… #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econd, nanosecond, ordinal_day for dask
|
Pull request number tho :P |
MarcoGorelli
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
thanks @aidoskanapyanov !
happy to take this - looks right, and if there's any issues, they should come up when we merge this with the main tests
Comment on lines
+310
to
+314
| def nanosecond(self) -> DaskExpr: | ||
| return self._expr._from_call( | ||
| lambda _input: _input.dt.microsecond * 1000, | ||
| "nanosecond", | ||
| ) |
There was a problem hiding this comment.
in fact, this one might not be correct, looking at how we do it in pandas_like, it should be _input.dt.microsecond * 1000 + _input.dt.nanosecond?
@aidoskanapyanov fancy fixing this in a follow-up pr?
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…econd, nanosecond, ordinal_day for dask
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Added some of the
dtmethods, mostly the trivial ones. Looking into how to implementtotal_*methods.