Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dask expr is_unique & is_duplicated #803

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Aug 16, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Edit: I just read @benrutter comment.

I don't think we should limit ourselves to what comes out of the box. It may not be the most performant operation, but if I had to have a logic such as:

if polars:
    ...
elif dask:
    ...

I would probably end up with something similar because that is not natively supported

@github-actions github-actions bot added the enhancement New feature or request label Aug 16, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, loving the creativity you bring to a lot of these πŸ™Œ

@MarcoGorelli MarcoGorelli merged commit 366f587 into main Aug 16, 2024
25 of 26 checks passed
@FBruzzesi FBruzzesi deleted the feat/dask-expr-is-dup branch August 16, 2024 17:29
@benrutter
Copy link
Contributor

This is absolutely freaking awesome @FBruzzesi!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants